Jump to content

Breaking Changes following 22379

Stan`

By Stan`,
in Announcements / News

 Share

Recommended Posts

  • Replies 52
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

Stan`
Stan`

Hello everyone, Following https://trac.wildfiregames.com/changeset/22379 there will be some changes needed for those of you who have mods modifying templates. I believe that's most of you. B

Silier
Silier

@gameboy there are a lot of problems he needs to fix, please be paitent

wraitii
wraitii

Hey @gameboy I am working on these issues, and uploading diffs regularly. They will be fixed, don't worry. Thanks for reporting them anyways  

  • 1 month later...
Freagarach Primus Pilus

Freagarach

Posted
Posted
  On 16/06/2019 at 6:44 PM, Stan` said:

This change will then allow any modder to add different types of attack to his mod.

Expand  

The followup (rP22527/D1938) has also been committed. This change means that not every damage type needs to be stated in all the templates (an armour of "0" is assumed against a non-declared damage type). No extra template changes are needed following this change.

Questions? Please ask :)

  • Thanks 1
Link to comment
Share on other sites
  • 1 month later...
wowgetoffyourcellphone Praetor

wowgetoffyourcellphone

Posted
Posted
  On 02/09/2019 at 7:47 AM, Stan` said:

What part of what @Nescio propose did you disagree with ?

Expand  

"Spear" is for the weapon. When I upgrade spears at the blacksmith, then every unit with a spear is upgraded, not just the "spearman" class. Nescio's patch strips out the weapon classes for unit classes, when before the unit classes were a combination of classes that put the weapon type front and center, e.g. "Spear Infantry," at least in DE. 

Link to comment
Share on other sites
wraitii Primus Pilus

wraitii

Posted
Posted
  On 02/09/2019 at 7:53 AM, wowgetoffyourcellphone said:

"Spear" is for the weapon. When I upgrade spears at the blacksmith, then every unit with a spear is upgraded, not just the "spearman" class. Nescio's patch strips out the weapon classes for unit classes, when before the unit classes were a combination of classes that put the weapon type front and center, e.g. "Spear Infantry," at least in DE. 

Expand  

To be honest SVN doesn't really work that way right now + we don't really have spear-specific upgrades. This is just a good example of how your mod handles things differently.

  • Like 1
Link to comment
Share on other sites
elexis Primus Pilus

elexis

Posted
Posted

rP22854 rewrote the main menu code.

Mods that wnat to specify their name to be displayed in the main menu can easily do so by adding a new file instead of rewriting mainmenu.xml.

@wowgetoffyourcellphone

Your mainmenu.xml contained this diff to svn:

  Reveal hidden contents

and I would recommend to delete this file and put this file under pregame/ProjectInformation_DelendaEst.js: 

g_ProjectInformation.productDescription.caption =
	setStringTags(translate("Delenda Est v0.0.03"), { "font": "sans-bold-16" }) + "\n\n" +
	translate("Notice: This mod is under development and many features have not been added yet.");

g_MainMenuItems[4].caption = translate("Atlas Scenario Editor");

g_CommunityButtons[0].tooltip = translate("Click to open https://0ad.mod.io/delenda-est in your web browser.");
g_CommunityButtons[0].onPress = () => {
	openURL("https://0ad.mod.io/delenda-est");
};

The mods that have more weblinks or information to add, see ProjectInformation.js:

  Reveal hidden contents

 

  • Like 4
Link to comment
Share on other sites
wowgetoffyourcellphone Praetor

wowgetoffyourcellphone

Posted
Posted (edited)

Neat. Looks useful. Got this though:

 

  Reveal hidden contents

 

Edited by wowgetoffyourcellphone
Link to comment
Share on other sites
Nescio Primus Pilus

Nescio

Posted
Posted
  On 06/09/2019 at 2:17 AM, elexis said:

rP22854 rewrote the main menu code.

Expand  

Today I noticed that clicking the History button when the Structure Tree window is opened no longer works in A24, nor does clicking the Structure Tree when the History window is opened. Interestingly, the hotkeys (Alt+Shift+H and Alt+Shift+T) do work. I don't know what broke the buttons, but the problem isn't there in A23.

Link to comment
Share on other sites
Stan` Consul

Stan`

Posted
  • Author
Posted
  On 06/09/2019 at 7:57 PM, Nescio said:

Today I noticed that clicking the History button when the Structure Tree window is opened no longer works in A24, nor does clicking the Structure Tree when the History window is opened. Interestingly, the hotkeys (Alt+Shift+H and Alt+Shift+T) do work. I don't know what broke the buttons, but the problem isn't there in A23.

Expand  

Can you check whether it's that commit and raise a concern if so ? Thank you

Link to comment
Share on other sites
elexis Primus Pilus

elexis

Posted
Posted
  On 06/09/2019 at 7:57 PM, Nescio said:

Today I noticed that clicking the History button when the Structure Tree window is opened no longer works in A24, nor does clicking the Structure Tree when the History window is opened. Interestingly, the hotkeys (Alt+Shift+H and Alt+Shift+T) do work. I don't know what broke the buttons, but the problem isn't there in A23.

Expand  

It works for me, any mods active? Or leftover mainmenu.xml? I suppose windows?

  On 06/09/2019 at 10:17 PM, wowgetoffyourcellphone said:

For a couple days now adjusting settings in game causes the game to pause with no dialogue. You have to pause and unpause again.

Expand  

I suppose that is the outdated menu.js copy. The commits after July 27th are missing. Your only change is this: 

--- /tmp/menu.js_orig	2019-09-07 01:04:59.261486333 +0200
+++ /tmp/menu.js_de	2019-09-07 01:03:29.124822542 +0200
@@ -849,7 +849,9 @@
 		});
 	};
 
-	barterButton.Buy.hidden = isSelected;
+	if (g_BarterSell == "coin"){
+		barterButton.Buy.hidden = isSelected;}
+	else {barterButton.Buy.hidden = resourceCode != "coin";}
 	barterButton.Buy.enabled = controlsPlayer(player);
 	barterButton.Sell.hidden = false;
 	selectionIcon.hidden = !isSelected;

Perhaps to keep track of your chances, you might want to store the diffs along the mod? i.e. the above in menu.js.diff, and then when theres a new menu.js in svn, you can apply the patch again rather than applying the svn commit to your copy.

  • Thanks 1
Link to comment
Share on other sites
Nescio Primus Pilus

Nescio

Posted
Posted
  On 06/09/2019 at 11:18 PM, elexis said:

It works for me, any mods active? Or leftover mainmenu.xml? I suppose windows?

Expand  

No mods active, just the newest svn version; gui/pregame/mainmenu.xml is identical to what it's supposed to be; and Fedora 30, not Windows.

Also, in game (session) the buttons do work. Only when opening them from the pre-game main menu clicking the History button in the Structure Tree window closes the Structure Tree, rather than opening the History window, and clicking the Structure Tree button in the History window closes the History, rather than opening the Structure Tree. And as said before, the hotkeys do work, so I don't really understand why the buttons don't on my end.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...