[FIXED] Water Redness

[gameboy]

 Today, I tested the latest version of SVN22302. When I started the game, there was a problem message on the main interface of the game: ‘WARNING: SDL_Set Windows Gamma Ramp failed.’

BTW: When I rotated the camera, I found the red box, which had never appeared before.    The map I used was the Mediterranean coast.

 

Edited June 20, 2019 by gameboy

[wraitii]

Hey gameboy, that's related to me merging D359 yesterday.

You can fix it by de-activating fancy effects as it turns out I can reproduce this (didn't notice yesterday, unluckily).

 

Edit - I'm interested in other people reporting SQL/GL error, by the way, as testing these shaders things is annoying at best.

[gameboy]

My friend, I'm waiting for you to fix it, thank you.

[gameboy]

@wraitii My old friend, please fix this problem, thank you!

[s0600204]

Your old friend is busy. Please have patience. In the meantime, you can test the proposed fix here: https://code.wildfiregames.com/D1919. If it works, then we can include it.

Edit: At 10:57 UTC today, the patch was committed. Your problem should now be fixed. Don't forget to update your local copy.

Edited May 28, 2019 by s0600204
Update with latest status.

[gameboy]

Today, I tested the latest 22314. When I started the game, a warning message appeared:

WARNING: SDL_SetWindowGammaRamp failed

@Angen @wraitii

[Itms]

Hi gameboy, the Windows autobuild is stopped for a few days for an upgrade. You can build the game if you want to get the fix! Sorry for the inconvenience

[Silier]

@gameboy after I build game I cannot reproduce sorry

btw @wraitii there are still red squares

[wraitii]

I think that might be the water refraction clipping?

[gameboy]

@Angen Which map are you using?

[Stan`]

  On 28/05/2019 at 10:19 PM, gameboy said:

@Angen Which map are you using?

Expand  

That's acropolis bay.

[gameboy]

@wraitii I used the latest SVN22316, and I compiled it with VS2013. This warning still appears:            WARNING: SDL_Set Windows Gamma Ramp failed            The operating system I use is win10 64 bit, 8G RAM

@Angen

Edited May 29, 2019 by gameboy

[gameboy]

@wraitii  @Angen I have found the reason why this warning always appears: 

  Reveal hidden contents

 

Error    6    error C2059: syntax error : ','    D:\trunk\source\collada\Decompose.cpp    278    1    Collada
Error    7    error C2143: syntax error : missing ';' before '='    D:\trunk\source\collada\Decompose.cpp    286    1    Collada
Error    8    error C2065: 'g1' : undeclared identifier    D:\trunk\source\collada\Decompose.cpp    287    1    Collada
Error    9    error C2100: illegal indirection    D:\trunk\source\collada\Decompose.cpp    287    1    Collada
Error    10    error C2065: 'g2' : undeclared identifier    D:\trunk\source\collada\Decompose.cpp    288    1    Collada
Error    11    error C2100: illegal indirection    D:\trunk\source\collada\Decompose.cpp    288    1    Collada
Error    12    error C2065: 'g1' : undeclared identifier    D:\trunk\source\collada\Decompose.cpp    290    1    Collada
Error    13    error C2065: 'g2' : undeclared identifier    D:\trunk\source\collada\Decompose.cpp    290    1    Collada
Error    151    error C3861: 'SDL_CalculateRamp': identifier not found    D:\trunk\source\ps\VideoMode.cpp    247    1    engine
Error    152    error C3861: 'SDL_SetWindowRamp': identifier not found    D:\trunk\source\ps\VideoMode.cpp    248    1    engine
Error    199    error LNK1181: cannot open input file 'D:\trunk\binaries\system\engine.lib'    D:\trunk\build\workspaces\vc2013\LINK    pyrogenesis
Error    210    error LNK1181: cannot open input file 'D:\trunk\binaries\system\engine.lib'    D:\trunk\build\workspaces\vc2013\LINK    test
    211    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    503    15    engine
    212    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    503    42    engine
    213    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    505    15    engine
    214    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    505    43    engine
    215    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    507    15    engine
    216    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    507    49    engine
    217    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    509    15    engine
    218    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    509    49    engine
    219    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    511    15    engine
    220    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    511    49    engine
    221    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    513    15    engine
    222    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    513    49    engine
    223    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    515    15    engine
    224    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    515    47    engine
    225    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    517    15    engine
    226    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    517    45    engine
    227    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    519    15    engine
    228    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    519    45    engine
    229    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    521    15    engine
    230    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    521    46    engine
    231    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    523    15    engine
    232    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    523    42    engine
    233    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    525    15    engine
    234    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    525    47    engine
    235    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    527    15    engine
    236    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    527    49    engine
    237    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    529    15    engine
    238    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\js\Class.h    529    43    engine
    239    IntelliSense: this operator is not allowed in a constant expression    d:\trunk\libraries\source\spidermonkey\include-win32-release\jspubtd.h    459    51    engine
    240    IntelliSense: identifier "SDL_CalculateRamp" is undefined    d:\trunk\source\ps\VideoMode.cpp    247    2    engine
    241    IntelliSense: identifier "SDL_SetWindowRamp" is undefined    d:\trunk\source\ps\VideoMode.cpp    248    6    engine

 

 

[s0600204]

(./source/ps/VideoMode.cpp, line 247)

Error appears self inflicted - this is the same code block as it appears in our code repository:

	u16 ramp[256];
	SDL_CalculateGammaRamp(g_Gamma, ramp);
	if (SDL_SetWindowGammaRamp(m_Window, ramp, ramp, ramp) < 0)
		LOGWARNING("SDL_SetWindowGammaRamp failed");

Looking at the history of the file, the line in question has never read SDL_CalculateRamp. Thus, this error appears to be caused by local modification by user.

Neither SDL_CalculateGammaRamp nor SDL_CalculateRamp appear anywhere else in the source files.

[gameboy]

I haven't changed any local files. I can't compile pyrogenesis now.

[Stan`]

Clean workspaces, delete vs folders  and try again. Since there were changes to the precompiled headers, you might have files that don't get recompiled for some reason.

[Itms]

@gameboy

Check all the boxes like in the screenshot and click OK, then update your copy and rebuild.

[gameboy]

@Itms  @Stan`

I have completely updated all the files in your way, but the warning message still appears:

WARNING: SDL_Set Windows Gamma Ramp failed

 

ERROR: CCacheLoader failed to find archived or source file for: "shaders/effects/postproc/hdr.xml"

 

ERROR: Failed to load effect'postproc/hdr'

报错

[Stan`]

  On 30/05/2019 at 5:48 AM, gameboy said:

@Itms  @Stan`

I have completely updated all the files in your way, but the warning message still appears:

WARNING: SDL_Set Windows Gamma Ramp failed

 

ERROR: CCacheLoader failed to find archived or source file for: "shaders/effects/postproc/hdr.xml"

 

ERROR: Failed to load effect'postproc/hdr'

报错

Expand  

Looks like you sir uded one of @aeonios's patch as a mod And forgot to either disable the mod or revert it.

[gameboy]

@Stan`

I didn't use anyone's MOD。

BTW: WARNING: SDL_Set Windows Gamma Ramp failed   This warning has disappeared.

These two mistakes still exist：

ERROR: CCacheLoader failed to find archived or source file for: "shaders/effects/postproc/hdr.xml"

 

ERROR: Failed to load effect'postproc/hdr'

 

They still appear in SVN.

 

Edited May 30, 2019 by gameboy

[Stan`]

Check if those files are in your folder. You might want to run svn update to restore the files;

[gameboy]

@Angen I didn't find the problem of refraction on this map. I tested it five times and it's gone.

[Silier]

I still can, you need to play with distance and angle

[gameboy]

@Angen My friend, I used the same Angle and distance as you, you can compare with the screenshot of the same problem I had before.

[Silier]

I said play with angle ( and hard to tell, your image is edited)

  Reveal hidden contents

  Reveal hidden contents