hyperion

Sure for release and CI builds anything newer then windows 7 sdk isn't an option, just meant to say if you build for yourself choose what you like.

It's unlikely that a newer toolset causes issues. C linkage is rather stable. Just take it as a well tested setup. If a newer toolset or Visual Studio causes problems reports are certainly welcome.

There is also a patch by @wraitii making attackers temporary visible so this would make a reasonable combo, probably attacked units should become visible as well. Compared to attack_range + ~70m vision_range which would only reasonably solve the issue this would be full solution.

Sure, just mentioned it to show it's not _that_ obvious. So minimum vision range is "horizontal shooting range" + "largest building size" / 2 + "some 30 meters for elevation to make it unlikely" for all units?

Imagine a map with height set to minimum everywhere except a column in the center with height set to max, now every ranged unit if placed on top the column can reach any point on map. So how much to increase the vision range to call it good enough?

Then what is your solution? Make SoD leaky (which IMHO is against it's purpose) or increase vision range of catapult to make it less obvious?

But if you don't have vision you don't know that it's already destroyed. You can just guess it but maybe your opponent snuck a few dozen repairers there in the meantime so you really can't be sure unless you check in which case the cata will stop firing. If it does stop firing without vision then it's a case of leaking info that the shroud of darkness is supposed to hide. Btw, this is not limited to catas but applies to all ranged units, it's just not as obvious for others due to relatively large vision range compared to shooting range.

Expected behavior. Why do you think it's a problem?

SM stand for spidermonkey, some distros call it mozjs and it looks your distro calls it simply js. https://software.manjaro.org/package/js91

Indeed, now I can reproduce. With python3-setuptools installed the following allows me to build 0ad in Debian SETUPTOOLS_USE_DISTUTILS=stdlib ./update-workspaces.sh @zyli phew, no reinstall needed --- Tried Fedora 37 and can build just fine. Wonder what I need to break that one (no, not setuptools)!

Thanks. Went through all skirmish maps and can't find any missing shaders anymore with 0ad-spirv-0.27.11. Also disabled validation to get an estimate an vulkan vs gl performance, it's mostly a tie. Some times one is slightly faster than the other and sometimes the other way around. Tho it feels like not comparing the exact same. For instance shore waves are rendered in gl without fancy while it requires fancy with vulkan, also using vulkan models throw shadows onto themself while in gl only onto other objects. To sum up overall they feel roughly the same performance wise. I also didn't come across other issues on the level as those 3 textures mentioned earlier in this thread. Those are the only issue I consider on the level of RB. Do you have an inkling of what is going on there? I just blindly adjusted props size to 64 from 60 as it's 2^6 and it happens to work for me.

Maybe ask on the Debain forums if my guess is reasonable and if you can fix it manually. Looking at the standalone build of mozjs91 at https://salsa.debian.org/gnome-team/mozjs/-/tree/debian/91/master I can't see an indication of your bug either. Sadly, I can't really help much with debugging if I can't reproduce the issue, just grasping at straws.

Same, can build pyrogenesis just fine using a Debian installed using the iso here https://cdimage.debian.org/cdimage/weekly-builds/amd64/iso-dvd/ *suspects some migration wrt python in the past left some breakage behind ...

I'll setup a vm with the installer you linked to and try to reproduce the issue later.

@zyli thanks for continuing to try. For all we know now the issue is due to install scheme and once fixed it should work for you and other Debian users. First try the patch from @s0600204 , it's inlined in the text and so you might have missed it. His patch looks like a clean approach to fix the issue. Apply it on a clean checkout and try to build 0ad. On the off chance it's not a complete fix you could try to do the symlink trick, if that works we are sure what the issue is and only need to find all places to change. For the symlink trick approch: export DEB_PYTHON_INSTALL_LAYOUT='deb' (needs to be done every time you open a new terminal) run "./update-wokspace.sh" the build fails then create the symlinks as suggested, don't clean the build or anything the like. run "REBUILD=false ./update-workspace.sh" If this succeeds we are sure to have found the cause and that there is nothing more to it. @Freagarach you might want to try as well.

Only distutils was either there or got pulled in by "apt-get build-dep 0ad"

There is an add action dropdown, select raise concern under audit action so the commit is marked as needs work. A comment might get forgotten.

you could create symlinks python3 -> python3.10 and dist-packages -> site-packages and resume the build

version 4.0.0 is to old, guess some commit to 0ad increased the minimum requirement. Edit: you might want to raise a concern: https://code.wildfiregames.com/rP27329

Wait! Grabbed a nocloud-amd64 image from https://cloud.debian.org/images/cloud/bookworm/daily/ installed build deps for 0ad cloned https://github.com/0ad/0ad ran update-workspace.sh ran make -> have a pyrogenesis binary.

Good call @s0600204 with this hint I found https://github.com/pypa/virtualenv/issues/2350 export DEB_PYTHON_INSTALL_LAYOUT='deb' Before starting the build might work

Just looked at fedoras 0ad package, they explicitly set a dependency on python3-setuptools but don't do anything further with it, maybe installing that package may help Edit: There seems to be also a python3-setuptools-whl package in debian.

lowercase <string.h> is part of libc, the system_wrapper/string.h includes next the lowercase version ... Your toolchain likes to capitalize, maybe switch to a case insensitive filesystem

Thanks for trying, I'm out of ideas https://tracker.debian.org/news/1356694/accepted-mozjs91-91130-1-source-into-unstable/ Looks like you could give that a try once --with-system-mozjs is fixed, see

it's getting harder to find missing one 0ad-spirv-0.27.10: ERROR: Program 'spirv/model_solid_tex' with required defines not found. ERROR: "IGNORE_LOS": "1" ERROR: "MODE_SHADOWCAST": "1" ERROR: "PASS_SHADOWS": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_TRANSPARENT": "1" ERROR: "USE_AO": "1" ERROR: "REQUIRE_ALPHA_GEQUAL": "0.4" ERROR: Failed to load shader 'spirv/model_solid_tex' ERROR: Program 'spirv/model_common' with required defines not found. ERROR: "ALPHABLEND_PASS_OPAQUE": "1" ERROR: "IGNORE_LOS": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_TRANSPARENT": "1" ERROR: "USE_AO": "1" ERROR: "REQUIRE_ALPHA_GEQUAL": "0.6375" ERROR: Failed to load shader 'spirv/model_common' ERROR: Program 'spirv/model_common' with required defines not found. ERROR: "ALPHABLEND_PASS_BLEND": "1" ERROR: "IGNORE_LOS": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_TRANSPARENT": "1" ERROR: "USE_AO": "1" ERROR: "REQUIRE_ALPHA_GEQUAL": "0.05" ERROR: Failed to load shader 'spirv/model_common' ERROR: Program 'spirv/model_solid_tex' with required defines not found. ERROR: "IGNORE_LOS": "1" ERROR: "MODE_SILHOUETTEOCCLUDER": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_TRANSPARENT": "1" ERROR: "USE_AO": "1" ERROR: "REQUIRE_ALPHA_GEQUAL": "0.4" ERROR: Failed to load shader 'spirv/model_solid_tex' ERROR: Program 'spirv/model_solid_tex' with required defines not found. ERROR: "IGNORE_LOS": "1" ERROR: "MODE_SILHOUETTEOCCLUDER": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_TRANSPARENT": "1" ERROR: "REQUIRE_ALPHA_GEQUAL": "0.4" ERROR: Failed to load shader 'spirv/model_solid_tex' ERROR: Program 'spirv/model_solid' with required defines not found. ERROR: "IGNORE_LOS": "1" ERROR: "MODE_SILHOUETTEOCCLUDER": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_AO": "1" ERROR: "USE_PLAYERCOLOR": "1" ERROR: Failed to load shader 'spirv/model_solid' ERROR: Program 'spirv/model_solid_tex' with required defines not found. ERROR: "IGNORE_LOS": "1" ERROR: "MODE_SHADOWCAST": "1" ERROR: "PASS_SHADOWS": "1" ERROR: "RENDER_DEBUG_MODE": "RENDER_DEBUG_MODE_NONE" ERROR: "SHADOWS_CASCADE_COUNT": "1" ERROR: "USE_DESCRIPTOR_INDEXING": "1" ERROR: "USE_INSTANCING": "1" ERROR: "USE_SHADOW": "1" ERROR: "USE_SHADOW_PCF": "1" ERROR: "USE_SHADOW_SAMPLER": "1" ERROR: "USE_FOG": "1" ERROR: "USE_NORMAL_MAP": "1" ERROR: "USE_SPECULAR_MAP": "1" ERROR: "USE_TRANSPARENT": "1" ERROR: "USE_AO": "1" ERROR: "USE_PARALLAX": "1" ERROR: "REQUIRE_ALPHA_GEQUAL": "0.4" ERROR: Failed to load shader 'spirv/model_solid_tex'