gameboy Posted February 6, 2020 Report Share Posted February 6, 2020 The latest SVN Changeset 23484 adds FXAA anti-aliasing. We're starting to have it, but do we still need MSAA anti-aliasing? Quote Link to comment Share on other sites More sharing options...
asterix Posted February 6, 2020 Report Share Posted February 6, 2020 5 hours ago, gameboy said: The latest SVN Changeset 23484 adds FXAA anti-aliasing. We're starting to have it, but do we still need MSAA anti-aliasing? @vladislavbelov said on Irc sometime back that he will extend it to other types too so I hope so. Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 6, 2020 Author Report Share Posted February 6, 2020 @vladislavbelov I have a suggestion: increase the multiples of FXAA, such as 2XFXAA and 4XFXAA, to enhance the anti-aliasing effect. Quote Link to comment Share on other sites More sharing options...
Stan` Posted February 6, 2020 Report Share Posted February 6, 2020 It's already maxed out when set. Quote Link to comment Share on other sites More sharing options...
asterix Posted February 6, 2020 Report Share Posted February 6, 2020 23 minutes ago, gameboy said: @vladislavbelov I have a suggestion: increase the multiples of FXAA, such as 2XFXAA and 4XFXAA, to enhance the anti-aliasing effect. From irc yesterday http://irclogs.wildfiregames.com/2020-02/2020-02-05-QuakeNet-%230ad-dev.log he said that those values could be chosen in other types MSAA. Plus @vladislavbelov will be happy if someone tested https://code.wildfiregames.com/D2621 and posted there results. Quote Link to comment Share on other sites More sharing options...
Sundiata Posted February 6, 2020 Report Share Posted February 6, 2020 Awesome! Quote Link to comment Share on other sites More sharing options...
vladislavbelov Posted February 6, 2020 Report Share Posted February 6, 2020 1 hour ago, asterix said: Plus @vladislavbelov will be happy if someone tested https://code.wildfiregames.com/D2621 and posted there results. It's more about performance and correctness, not about visual improvement (may only on broken cards, which can't mix ARB and GLSL shaders). 1 hour ago, asterix said: From irc yesterday http://irclogs.wildfiregames.com/2020-02/2020-02-05-QuakeNet-%230ad-dev.log he said that those values could be chosen in other types MSAA. For MSAA we have such values because it uses multi-sampling (Multi-Sampling Anti-Aliasing). And a possible option controls number of samples per edge pixel. 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 6, 2020 Author Report Share Posted February 6, 2020 I'm going to test this patch, and I hope @vladislavbelov implements MSAA anti-aliasing. MSAA anti-aliasing effect will be better. Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 6, 2020 Author Report Share Posted February 6, 2020 @vladislavbelov If you can implement MSAA anti aliasing in the near future, I will help you test this function and give feedback here. Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 6, 2020 Author Report Share Posted February 6, 2020 @vladislavbelov I tested the patch you provided and there was no problem with the game crashing. I turned on the GLSL feature. Quote Link to comment Share on other sites More sharing options...
nani Posted February 6, 2020 Report Share Posted February 6, 2020 (edited) 2xFXAA 4xFXAA etc basically defines how far the FXAA algorithm looks for lines that can smooth. Turns out that FXAA is usually so cheap having it at max is a good default. Notice that I don't mean how many points are area samples but how far the algorithm will follow a line to smooth (and get a better result). Edited February 6, 2020 by nani 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 7, 2020 Author Report Share Posted February 7, 2020 Let's hope MSAA anti-aliasing comes soon. Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 23, 2020 Author Report Share Posted February 23, 2020 @vladislavbelov Quote Link to comment Share on other sites More sharing options...
asterix Posted February 23, 2020 Report Share Posted February 23, 2020 1 hour ago, gameboy said: @vladislavbelov there is also now https://code.wildfiregames.com/D2642 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 23, 2020 Author Report Share Posted February 23, 2020 ERROR: Failed to compile shader 'shaders/glsl/cas.fs': 0(64) : warning C1503: undefined variable "rcp" 0(70) : warning C1503: undefined variable "rcp" 0(73) : warning C1503: undefined variable "rcp" 0(64) : error C1008: undefined variable "rcp" 0(70) : error C1008: undefined variable "rcp" 0(73) : error C1008: undefined variable "rcp" Quote Link to comment Share on other sites More sharing options...
OptimusShepard Posted February 23, 2020 Report Share Posted February 23, 2020 7 hours ago, gameboy said: ERROR: Failed to compile shader 'shaders/glsl/cas.fs': 0(64) : warning C1503: undefined variable "rcp" 0(70) : warning C1503: undefined variable "rcp" 0(73) : warning C1503: undefined variable "rcp" 0(64) : error C1008: undefined variable "rcp" 0(70) : error C1008: undefined variable "rcp" 0(73) : error C1008: undefined variable "rcp" "rcp" seems to be an AMD optimized function. I have replaced it. You could test the patch again. Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 24, 2020 Author Report Share Posted February 24, 2020 (edited) @OptimusShepard I use an Intel CPU and a NVIDIA GTX850M graphics card. The operating system is Windows10 64bit Edited February 24, 2020 by gameboy Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 24, 2020 Author Report Share Posted February 24, 2020 @OptimusShepard I used your new patch, no error message, but I found the details of anti aliasing. I enabled CAS in the game, and found that the aliasing still exists. Quote Link to comment Share on other sites More sharing options...
OptimusShepard Posted February 24, 2020 Report Share Posted February 24, 2020 (edited) Thanks for testing CAS (contrast adaptiv sharpening) isn't against aliasing, it's an sharpening pass. By using FXAA the game gets much more blurry. CAS could reduce/avoid this blurryness. So I would recommend to use this both options together. FXAA isn't perfect. But as the algorithem of FXAA and CAS are realy cheap in performance usage, thats a realy good quality/performance compromise. Especially for older computers. If vladislav or someone else will has the time, he/she will implement another better algorithem. But I would guess that's currently less priority. Edited February 24, 2020 by OptimusShepard 1 2 Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 24, 2020 Author Report Share Posted February 24, 2020 FXAA should have a 2 - or 4-fold antialiasing. @vladislavbelov Quote Link to comment Share on other sites More sharing options...
OptimusShepard Posted February 25, 2020 Report Share Posted February 25, 2020 @gameboy I added a slider option to the sharpening pass, maybe you want to test it? 1 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted February 26, 2020 Author Report Share Posted February 26, 2020 @OptimusShepard I have tested your new patch, which seems to require a stronger sharpening effect. Quote Link to comment Share on other sites More sharing options...
OptimusShepard Posted February 26, 2020 Report Share Posted February 26, 2020 1 hour ago, gameboy said: @OptimusShepard I have tested your new patch, which seems to require a stronger sharpening effect. What do you mean when you said it needs a stronger sharpening effect? Do you mean the default value? The original patch has a static sharpness factor of 0,5. The new patch allows you to select a sharpness value between 0,0 and 1,0 by slider. The default is set to 0,3. A value greater than 1,0 would lead to colour noise. 1 Quote Link to comment Share on other sites More sharing options...
asterix Posted November 16, 2020 Report Share Posted November 16, 2020 @gameboy @OptimusShepard MSAA https://trac.wildfiregames.com/changeset/24188 was just committed. 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.