gameboy Posted June 4, 2019 Author Report Share Posted June 4, 2019 Do you have a good solution? 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 @Angen This is a previous patch, and if anyone can change it, these flood problems will be solved. TerrainRenderer.cpp.patch Quote Link to comment Share on other sites More sharing options...
vladislavbelov Posted June 5, 2019 Report Share Posted June 5, 2019 5 minutes ago, gameboy said: @Angen This is a previous patch, and if anyone can change it, these flood problems will be solved. TerrainRenderer.cpp.patch 2.74 kB · 0 downloads This is my patch from #2692, it solves water blocks that we didn't render before because of scissoring. Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 (edited) yes, But it still has red water problems. The problem needs to be fix. Edited June 5, 2019 by gameboy Quote Link to comment Share on other sites More sharing options...
wraitii Posted June 5, 2019 Report Share Posted June 5, 2019 42 minutes ago, vladislavbelov said: This is my patch from #2692, it solves water blocks that we didn't render before because of scissoring. Did you ever upload that to Phabricator? Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 @vladislavbelov Attached patch does not seem to fix the issue. The refraction map still sometimes lag behind the camera weirdly. Quote Link to comment Share on other sites More sharing options...
Silier Posted June 5, 2019 Report Share Posted June 5, 2019 @gameboy , @vladislavbelov, @wraitii I combined https://trac.wildfiregames.com/attachment/ticket/2692/TerrainRenderer.cpp.patch and https://code.wildfiregames.com/D1954. I could not reproduce red water thing. Could someone confirm that or tell at which maps does it happen ? Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 @Angen Thank you very much for your help, my friend. I'll test your patch right away. If I find any problems, I'll tell you here. Quote Link to comment Share on other sites More sharing options...
Silier Posted June 5, 2019 Report Share Posted June 5, 2019 Now thinking about it I have no idea how D1954 could affect it. Did you test vladislav patch with recent svn? Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 @Angen I've tested your patch and found red water. The map I used was: the Mediterranean coast, the Thessaly Plain. When I rotate the camera. Quote Link to comment Share on other sites More sharing options...
vladislavbelov Posted June 5, 2019 Report Share Posted June 5, 2019 1 hour ago, wraitii said: Did you ever upload that to Phabricator? Nope 21 minutes ago, Angen said: Now thinking about it I have no idea how D1954 could affect it. Did you test vladislav patch with recent svn? I think D1954 shouldn't affect the redness. My patch doesn't solve the whole problem only not rendered blocks (patches). Quote Link to comment Share on other sites More sharing options...
Silier Posted June 5, 2019 Report Share Posted June 5, 2019 10 minutes ago, gameboy said: @Angen I've tested your patch and found red water. The map I used was: the Mediterranean coast, the Thessaly Plain. When I rotate the camera. I know my patch alone does not solve it 4 minutes ago, vladislavbelov said: I think D1954 shouldn't affect the redness. My patch doesn't solve the whole problem only not rendered blocks (patches). I will do more tests to see, can you tell at which situations it did not work? as reported redness in this forum thread is resolved for me with it. maybe it would be good retest with recent wraitii's changes in shaders 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 (edited) @Angen When I rotated the camera lens and moved it up and down, I found that the sea would overlap. I tested several maritime maps. BTW: I didn't find red water. Then I found a splitting line on the surface of the water. The color of the splitting line was very light, but as long as I drew close to the camera lens and moved it back and forth, I could find it. Edited June 5, 2019 by gameboy Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 5, 2019 Author Report Share Posted June 5, 2019 @Angen Quote Link to comment Share on other sites More sharing options...
Lion.Kanzen Posted June 5, 2019 Report Share Posted June 5, 2019 (edited) 14 minutes ago, gameboy said: @Angen one time is enough, at last give to him time to finish the patch and lunch a good meal. Edited June 5, 2019 by Lion.Kanzen 1 1 Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 6, 2019 Author Report Share Posted June 6, 2019 @Angen Just now, I tested this patch again. I tested the map of the Mediterranean coast. When I moved the camera up and down, the water texture overlapped. Quote Link to comment Share on other sites More sharing options...
Silier Posted June 6, 2019 Report Share Posted June 6, 2019 thank you for report, I found some more edge cases. Looks like most likely some part of texture is not rendered when camera moves and you are close to water level. But then it should be red. Or it is rendered with wrong projection matrix. This will take some time to figure out and fix. 1 Quote Link to comment Share on other sites More sharing options...
wraitii Posted June 6, 2019 Report Share Posted June 6, 2019 1 hour ago, Angen said: thank you for report, I found some more edge cases. Looks like most likely some part of texture is not rendered when camera moves and you are close to water level. But then it should be red. Or it is rendered with wrong projection matrix. This will take some time to figure out and fix. I'm repeating myself but that looks like the scissoring issue :p . We don't clear the reflection/refraction textures, so here the texture is rendered with the old data, so it's not (necessarily) red. 2 Quote Link to comment Share on other sites More sharing options...
gameboy Posted June 9, 2019 Author Report Share Posted June 9, 2019 @vladislavbelov Do you have any good solutions? Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.