Suggestion: One voice actor per unit

[ubik]

I've found that clicking on a unit multiple times and having him/her change voices each time breaks the illusion of the game. Would it be possible/easy to assign only one audio file per unit? I think it would help with the realism.

Thanks.

[Lion.Kanzen]

  On 15/12/2017 at 8:47 PM, ubik said:

I've found that clicking on a unit multiple times and having him/her change voices each time breaks the illusion of the game. Would it be possible/easy to assign only one audio file per unit? I think it would help with the realism.

Thanks.

Expand  

We even haven't finish some audio yet. we lack of audio department.

[feneur]

  On 15/12/2017 at 9:02 PM, Lion.Kanzen said:

We even haven't finish some audio yet. we lack of audio department.

Expand  

True, but this is a different thing: the sound system uses the existing sound files and slightly changes them to make it sound as if there are more different sounds than there actually is. So the solution might be to tie that modification to the entity rather than just have it random

[wowgetoffyourcellphone]

  On 16/12/2017 at 8:28 AM, feneur said:

True, but this is a different thing: the sound system uses the existing sound files and slightly changes them to make it sound as if there are more different sounds than there actually is. So the solution might be to tie that modification to the entity rather than just have it random

Expand  

Can bind the randomized pitch to the entity ID. 

[Stan`]

I think there is a ticket about it. Can't find it though.

So it's somewhat planned.

[fabio]

This is the ticket: #3578.

[Lion.Kanzen]

  On 16/12/2017 at 8:46 AM, wowgetoffyourcellphone said:

Can bind the randomized pitch to the entity ID. 

Expand  

I don't  like my voice in high pitched.

[Lion.Kanzen]

  On 16/12/2017 at 8:28 AM, feneur said:

True, but this is a different thing: the sound system uses the existing sound files and slightly changes them to make it sound as if there are more different sounds than there actually is. So the solution might be to tie that modification to the entity rather than just have it random

Expand  

 is important too, no only variance of pitch.

[feneur]

  On 16/12/2017 at 2:54 PM, Lion.Kanzen said:

I don't  like my voice in high pitched.

Expand  

The variance could be limited so it doesn't go up (or down) too far

[Lion.Kanzen]

Other can be make is get more phrase to say like StarCraft or  Total War , he said something similar.

  Quote

that clicking on a unit multiple times

Expand  

 

[Andrettin]

  On 16/12/2017 at 8:46 AM, wowgetoffyourcellphone said:

Can bind the randomized pitch to the entity ID. 

Expand  

That's a good idea. A solution could be to use the modulo operator on the entity ID, with the quantity of different pitches. The resulting number then would be used to select the pitch for that entity. It would no longer be randomized, but it feel random in most cases, and it would automatically be bound to the entity ID.

[Stan`]

Patches are welcome 

[Andrettin]

  On 17/12/2017 at 9:15 AM, stanislas69 said:

Patches are welcome 

Expand  

I'm not sure I am familiar enough with the code base to produce one, but I took a look at the code, and this could work:

float((m_PitchLower * 100.0f + source % (int((m_PitchUpper - m_PitchLower) * 100.0f) + 1)) / 100.0f)

(replacing  the call to RandFloat in line 207 of /source/soundmanager/scripting/SoundGroup.cpp)

[Stan`]

@Andrettin I'm probably less knowledgeable about that part of the code than you now are 

To get your patch reviewed you need to go through this

https://trac.wildfiregames.com/wiki/SubmittingPatches

Thanks for looking into this.

[elexis]

I agree that it is awkward that one unit would speak with two different voices. The performance part might be considered, but likely not problematic.

I would suggest to write a ticket at http://trac.wildfiregames.com/.

[Stan`]

  On 16/12/2017 at 10:13 AM, fabio said:

This is the ticket: #3578.

Expand  

@elexis I guess it could merged with this one.