[FIXED] Water Redness

[gameboy]

@Angen I opened all the functions in the settings.

Edited May 31, 2019 by gameboy

[gameboy]

@Angen  My friend, I may have played a little joke with you before, but now you will not see this problem appear.

I compiled the latest 0 A.D. and I'll upload it here later, so you can download it and test it, and it won't cause any more refraction problems on the water.

 

Edited June 3, 2019 by gameboy

[gameboy]

@wraitii  I tested the latest SVN22332, and that warning message still appears, as long as you choose the option of water surface refraction in the settings. When I restart the computer and start the game again, this warning will appear in the main interface of the game.    WARNING: SDL_SetWindowGammaRamp failed

[wraitii]

@gameboy Are you sure that you aren't using any mods? It certainly looks like you are, as nobody else is getting these gamma ramps error (from what we can tell).

 

@Angen Any chance you could check if this redness happened before the rP22297 commit? I think they should.

[Silier]

@wraitii good thinking, rP22297 just makes it more visible, it exists before that commit.

[gameboy]

@wraitii I didn't use any other mod。

[Silier]

@gameboy try to update graphic drivers

[gameboy]

I'm using the latest graphics driver.

[vladislavbelov]

9 minutes ago, gameboy said:

I'm using the latest graphics driver.

Are you able to reproduce the issue each time (each run)?

Also you could apply the following patch and compile the game:

diff --git a/source/ps/VideoMode.cpp b/source/ps/VideoMode.cpp
index 5cca5fe0d9..9d426f7690 100644
--- a/source/ps/VideoMode.cpp
+++ b/source/ps/VideoMode.cpp
@@ -246,7 +246,7 @@ bool CVideoMode::InitSDL()
        u16 ramp[256];
        SDL_CalculateGammaRamp(g_Gamma, ramp);
        if (SDL_SetWindowGammaRamp(m_Window, ramp, ramp, ramp) < 0)
-               LOGWARNING("SDL_SetWindowGammaRamp failed");
+               LOGWARNING("SDL_SetWindowGammaRamp failed: %s", SDL_GetError());
 #endif
 
        m_IsInitialised = true;

And then post the output of the warning here.

[gameboy]

Yes!

[wraitii]

3 hours ago, Angen said:

@wraitii good thinking, rP22297 just makes it more visible, it exists before that commit.

Is the "more visible" still in effect after the fixing commit? I think what you're running into is the water scissoring code being broken, something which I've always felt was beyond me to fix (it's geometry and I suck at geometry).

[Silier]

"more visible" = it is red, not blue

[vladislavbelov]

11 minutes ago, Angen said:

"more visible" = it is red, not blue

I suppose @wraitii is right, because we didn't fix redness of scissoring yet.

[gameboy]

Oh, my god, who's going to fix this?

[Stan`]

Just now, gameboy said:

Oh, my god, who's going to fix this?

It should have been fixed in https://trac.wildfiregames.com/changeset/22334

[gameboy]

@Stan`  Fix the red water problem, or fix the warning message that appeared?

[Stan`]

Red water.

You haven't given us the error message with the patch above.

[gameboy]

I also gave the red water patch, but it seemed immature, so I cancelled it.

[Stan`]

The patch above is a debug patch. It is used to get more information about the error you are encountering. If you don't test it we can't fix it.

[gameboy]

@Stan`  @Angen Today, I tested the latest SVN22335 and found that red water still exists. The map I tested was: Mediterranean coast.  

And maps: the Thessaly Plain.

Edited June 4, 2019 by gameboy

[Silier]

that strange I tested yesterday with all water effects, but not exactly that maps, I try today again and let you know. On the last 3 pictures there is no water right? is it just under water level? 

[gameboy]

@Angen  There are puddles, puddles have water, the back three maps have puddles, you can test. When you test, you will find these problems.

[Silier]

Thank you for report. This is very strange behaviour. It is again refraction problem. It looks like very specific by angle. Last 3 I can reproduce without problem. First is a bit hard. One has to go with angle under water and then come back. My guess is that something is not cleared at correct way.

[gameboy]

@Angen You just pull the camera in and rotate it, and you can see these problems. I'm not diving.

[wraitii]

All of the above look like the old scissoring issue to me, where the water isn't correctly being refreshed and so it shows red.