Lagging when using Shift- modifier key

[wowgetoffyourcellphone]

When using shift to place multiple buildings or to batch train, a large drop in framerate is noticed. I am not sure if it is my computer's local config [like some kind of "easy keys" option or something triggered by the shift key] or if it's a 0 A.D. problem. I've noticed this for a long time now, but just now mentioning it.

Edited February 27, 2018 by wowgetoffyourcellphone

[elexis]

I can't reprodue it, I get 54 FPS before and while pressing.

The building placement should not influenced at all by holding shift, as that is only tested when doing the mouseclick.

I suspected it's the massbartering. The numbers in that dialog are updated when pressing or releasing the key (see massbarter in misc.xml).

Does the framedrop occur while keeping it pressed or only on keydown/release?

You could rename your user.cfg to use the default config and see if the problem persists.

Next the specific lagging hotkey should be identified. Could rip out the mentioned massbarter event, or reassign hotkeys from Shift to something else.

[Lion.Kanzen]

Confirmed.

The problem only occurs keeping the shift. and isn't new have two alphas I think.

Edited February 27, 2018 by Lion.Kanzen

[elexis]

If I was allowed to guess wildly, I'd say windows behaves differently than linux with regards to sending the keydown/keyup even to the GUI and updates the barter panel all the time while holding it - whereas on linux only when actually pressing the first time or releasing.

Someone could add this debug line to misc.xml to see if that's the case

	<object hotkey="session.massbarter">
		<action on="Press">
            warn("Updating barter panel"); // INSERTION
			updateSelectionDetails();
			updateBarterButtons();
		</action>

		<action on="Release">
            warn("Updating barter panel"); // INSERTION
			updateSelectionDetails();
			updateBarterButtons();
		</action>
	</object>

 

[Stan`]

@elexis Just tested, as long as you press Shift you keep getting warnings.

[elexis]

ffs

[elexis]

Actually it works this way on linux too. We can see it with the toggle trade dialog hotkey (Ctrl+B).

When pressing it, it toggles once. While keeping it pressed further, after a second it starts to toggle back and forth.

But I totally can't see any FPS decline, not even 1 FPS, no matter if I'm at 50 or 20 fps.

We could figure out which of the hotkeys is the performance heavy one.

But I also recall causative sometime saying that the frequency of the event is different on windows than linux, that would explain it.

@causative do you remember in which context that was? (We had added a custom frequency  in rP19658, g_StatusBarUpdate, but that's not a hotkey frequency).

[elexis]

Also can someone who does experience the lag test if the lagging is gone if the 'session.massbarter' and 'session.batchtrain' part of misc.xml is deleted? I suspect both of them are equally lagging?

[elexis]

delay, delay #5055

[wowgetoffyourcellphone]

7 hours ago, elexis said:

misc.xml

Where can I find this, dude? 

[Stan`]

Windows Search ?

[wowgetoffyourcellphone]

6 minutes ago, stanislas69 said:

Windows Search ?

I tried searching in /public mod with the Windows search feature but it refused to find it. I tried from binaries level and search found it.

mods\public\gui\session\hotkeys 

 

[wowgetoffyourcellphone]

4 hours ago, elexis said:

Also can someone who does experience the lag test if the lagging is gone if the 'session.massbarter' and 'session.batchtrain' part of misc.xml is deleted? I suspect both of them are equally lagging?

Yes, removing this reduces or eliminates the lag.

Another thing that causes lag [I think] are sound calls, especially when they are first played.

Edited February 28, 2018 by wowgetoffyourcellphone

[Stan`]

Only in SVN or even with the packaged game ?

[causative]

4 hours ago, elexis said:

Actually it works this way on linux too. We can see it with the toggle trade dialog hotkey (Ctrl+B).

When pressing it, it toggles once. While keeping it pressed further, after a second it starts to toggle back and forth.

But I totally can't see any FPS decline, not even 1 FPS, no matter if I'm at 50 or 20 fps.

We could figure out which of the hotkeys is the performance heavy one.

But I also recall causative sometime saying that the frequency of the event is different on windows than linux, that would explain it.

@causative do you remember in which context that was? (We had added a custom frequency  in rP19658, g_StatusBarUpdate, but that's not a hotkey frequency).

It might have been someone else.  I don't use windows myself.  The only vaguely related thing I could find in my IRC logs is that Windows does not prevent alt+tab from reaching the application - so alt+tab will toggle status bars - and Linux does.

[wowgetoffyourcellphone]

34 minutes ago, stanislas69 said:

Only in SVN or even with the packaged game ?

The sound thing is probably just SVN now that I think of it.

[Imarok]

Refs #4915

[Nescio]

36 minutes ago, Imarok said:

Refs #4915

Actually I don't think it's a 0 A.D. issue; the game seems to be behave as it's supposed to. On Fedora, the “repeat keys” feature is activated by default, but it can be turned off or have a different sensitivity:

Likewise, I'd expect other operating systems to be able to toggle this non-0 A.D. feature as well.

[wowgetoffyourcellphone]

7 hours ago, Nescio said:

Actually I don't think it's a 0 A.D. issue; the game seems to be behave as it's supposed to. On Fedora, the “repeat keys” feature is activated by default, but it can be turned off or have a different sensitivity:

Likewise, I'd expect other operating systems to be able to toggle this non-0 A.D. feature as well.

Perhaps, but I don't remember experiencing shift key lag from other RTS games. Maybe I will test another RTS game and see.

[Nescio]

4 minutes ago, wowgetoffyourcellphone said:

Perhaps, but I don't remember experiencing shift key lag from other RTS games. Maybe I will test another RTS game and see.

Actually I was referring to Imarok's #4915 (hotkey repeat) and not to #5055 (shift lag).

[elexis]

On our machines the hotkey event is sent less often than on your machines, so we didn't notice it being a problem.

If the GUI updates it less often than the hotkey event frequency, the lag should be gone independent of the hotkey event frequency.

[wowgetoffyourcellphone]

On 3/2/2018 at 11:50 AM, elexis said:

On our machines the hotkey event is sent less often than on your machines, so we didn't notice it being a problem.

If the GUI updates it less often than the hotkey event frequency, the lag should be gone independent of the hotkey event frequency.

Has this been fixed? 

[bb_]

not yet, there is a patch at https://code.wildfiregames.com/D1398

[elexis]

I heard it not only reduces FPS but even freezes on some machines for the duration the key is pressed?

[wowgetoffyourcellphone]

5 hours ago, elexis said:

I heard it not only reduces FPS but even freezes on some machines for the duration the key is pressed?

Sometimes it causes such a reduction in FPS to be confused with freezing in my experience.

Edited July 8, 2018 by wowgetoffyourcellphone