===[COMMITTED]=== Update gatherer actors to have idle-carry animations

[wraitii]

As done in https://code.wildfiregames.com/rP20631, we should update all gatherer actors so that they can support having idle carrying animations.

This should/could be done incrementally, but in general I think a class of unit should be done across all civs at once.

[Stan`]

1 hour ago, wraitii said:

As done in https://code.wildfiregames.com/rP20631, we should update all gatherer actors so that they can support having idle carrying animations.

This should/could be done incrementally, but in general I think a class of unit should be done across all civs at once.

Minor ranting :

Spoiler

 

I see you went for comments in XML files. I still think it would have been better to do something like :
 

  <group name="base_overload">
    <variant file="biped/female_base_walk.xml"/>
    <variant file="biped/female_carry_food.xml"/>
    <variant file="biped/female_carry_meat.xml"/>
    <variant file="biped/female_carry_wood.xml"/>
    <variant file="biped/female_carry_stone.xml"/>
    <variant file="biped/female_carry_metal.xml"/>
  </group>

instead of :

  <group>
    <!-- In this group, defined overloads for "Idle", "Walk" and "Run" -->
    <variant file="biped/female_base_walk.xml"/>
    <variant file="biped/female_carry_food.xml"/>
    <variant file="biped/female_carry_meat.xml"/>
    <variant file="biped/female_carry_wood.xml"/>
    <variant file="biped/female_carry_stone.xml"/>
    <variant file="biped/female_carry_metal.xml"/>
  </group>

 because it now means we have a lot of comments maintaining to do, while those could have been in the wiki. @leper

 

I'll add updating those actors to my list of tasks. It's a good occasion to clean up the actor files.

[wraitii]

I don't think the comments necessarily need to be added to other files, tbh. They can be added to the wiki if you judge it necessary.

They're accurate anyhow and their presence or absence doesn't affect other files.

[Thorfinn the Shallow Minded]

Another relevant thing to consider adding is walking empty animations.  In that sense, when units are assigned an economic role, they walk using the implements they are using for the task even if they have no resources.

[wowgetoffyourcellphone]

On 12/10/2017 at 5:22 AM, wraitii said:

As done in https://code.wildfiregames.com/rP20631, we should update all gatherer actors so that they can support having idle carrying animations.

This should/could be done incrementally, but in general I think a class of unit should be done across all civs at once.

I look forward to this, because now the males look funny when shuttling resources.

[Stan`]

@wowgetoffyourcellphone If you want to help me I'd be happy. I was thinking to write a script to make mod update easier , I don't think I'll have the time though.

[wraitii]

Yes I've apparently missed something in my review, I'll try and fix it this WE.

[Stan`]

All the units have been updated, only missing the patch @wraitii