Delenda Est: An overhaul mod for 0 A.D.

[Stan`]

@Silier, @Freagarach, @JCWasmx86 , are from time to time.

[CovenantKillerJ]

Hey, so I tried running Delenda est (the one from github) on A26 christmas build, and this has came up which is the same with other mods updated to A26 such as Han Chinese. 

Any ideas?

EDIT: for some reason the log refuses to appear when I screenshot it.

Edited March 12, 2022 by CovenantKillerJ

[wowgetoffyourcellphone]

Github works with svn only. Also, there are a lot of broken things right now 

[CovenantKillerJ]

Cheers, I didn't read the beginning of the thread 

 

[anony5496]

Hi guys! Need some help here.

I'm playing 0ad on M1 Mac with Delenda Est, and so far I've been enjoying it very much. It's just that whenever I try to play the Nomad mode (by toggling the Nomad option), the game will fail to load. A window will pop up, saying "Error generating random map. Check application log for details," and there'll be a few lines on the interface as below:-

[34.996] error: JavaScript error: maps/random/rmgen-common/player.jsline471
[34.996] error: Script value conversion check failed v.isString() || v.isNumber() || v.isBoolean() (got type undefimed)
[34.996] error: placePlayersNomad@maps/random/rmgen-common/player.js:471:12
[34.996] error: @maps/random/red_sea.js: 353:18
[34.996] error: CMapGeneratorWorker:: Run: Failed to Load RMS 'maps/random/red_sea.js'

I did some trial and error, so I'm pretty sure that this only happens when I toggle the Nomad option.

I tried to uninstall, then reinstall both the game and the mod (I'm a complete noob when it comes to computers), but it didn't work. Then I tried switching to the newly released ARM native test build for M1 Mac, but it didn't work either. I tried Googling for solutions, but there aren't any. Am I the only person having this issue here? Huge thanks to anyone who can help me with this problem =)

Edited April 27, 2022 by anony5496

[wowgetoffyourcellphone]

Maybe because nomad mode places female_citizens, when DE doesn't have female_citizens?

[anony5496]

Thanks for the quick reply! So you mean nomad mode can't be played on DE at all? Or is there something that I can do?

[Stan`]

I haven't found anything related to that but maybe you need something extra in the civ.jsons

[wowgetoffyourcellphone]

Do you know which files deal with the nomad mode? @Freagarach @Stan`

[wowgetoffyourcellphone]

Looks like it's getting hung up on the treasure generation for some reason.

[wowgetoffyourcellphone]

Here's the section

function placePlayersNomad(playerClass, constraints)
{
	if (!isNomad())
		return undefined;

	g_Map.log("Placing nomad starting units");

	let distance = scaleByMapSize(60, 240);
	let constraint = new StaticConstraint(constraints);

	let numPlayers = getNumPlayers();
	let playerIDs = shuffleArray(sortAllPlayers());
	let playerPosition = [];

	for (let i = 0; i < numPlayers; ++i)
	{
		let objects = getStartingEntities(playerIDs[i]).filter(ents => ents.Template.startsWith("units/")).map(
			ents => new SimpleObject(ents.Template, ents.Count || 1, ents.Count || 1, 1, 3));

		// Add treasure if too few resources for a civic center
		let ccCost = Engine.GetTemplate("structures/" + getCivCode(playerIDs[i]) + "/civil_centre").Cost.Resources;
		for (let resourceType in ccCost)
		{
			let treasureTemplate = g_NomadTreasureTemplates[resourceType];

			let count = Math.max(0, Math.ceil(
				(ccCost[resourceType] - (g_MapSettings.StartingResources || 0)) /
				Engine.GetTemplate(treasureTemplate).Treasure.Resources[resourceType]));

			objects.push(new SimpleObject(treasureTemplate, count, count, 3, 5));
		}

		// Try place these entities at a random location
		let group = new SimpleGroup(objects, true, playerClass);
		let success = false;
		for (let distanceFactor of [1, 1/2, 1/4, 0])
			if (createObjectGroups(group, playerIDs[i], new AndConstraint([constraint, avoidClasses(playerClass, distance * distanceFactor)]), 1, 200, false).length)
			{
				success = true;
				playerPosition[i] = group.centerPosition;
				break;
			}

		if (!success)
			throw new Error("Could not place starting units for player " + playerIDs[i] + "!");
	}

	return [playerIDs, playerPosition];
}

 

Here is the line (471):

			let treasureTemplate = g_NomadTreasureTemplates[resourceType];

 

 

I tried bypassing treasure generation by setting the starting resources to 1000, but then I got an error for line 475:

ERROR: JavaScript error: maps/random/rmgen-common/player.js line 475 Script value conversion check failed: v.isString() || v.isNumber() || v.isBoolean() (got type undefined) placePlayersNomad@maps/random/rmgen-common/player.js:475:12 @maps/random/mainland.js:192:18

ERROR: CMapGeneratorWorker::Run: Failed to load RMS 'maps/random/mainland.js'

 

Line 475:

				Engine.GetTemplate(treasureTemplate).Treasure.Resources[resourceType]));

 

Could the "problem" be that Delenda Est's treasures give more than 1 resource?  A few months ago @Freagarach made it possible in the core game, so I ran with it. This could be an edge case not tested for? 

[Freagarach]

Well, if

g_NomadTreasureTemplates[resourceType]

is not defined, the rest won't work. ^^

Do your CCs cost glory or coins?

[wowgetoffyourcellphone]

1 hour ago, Freagarach said:

Well, if

g_NomadTreasureTemplates[resourceType]

is not defined, the rest won't work. ^^

Do your CCs cost glory or coins?

No, only wood and stone.

[Freagarach]

On 28/04/2022 at 8:40 AM, wowgetoffyourcellphone said:

No, only wood and stone.

Well, yes and no. They cost "0" coin and glory (inherited from template_structure), which means

for (let resourceType in ccCost)

will still loop over coin and glory. But

g_NomadTreasureTemplates[resourceType]

then doesn't exist, such that

Engine.GetTemplate(treasureTemplate)

will fail.

You(/We) have some options to fix this:

• Add coin and glory treasures to g_NomadTreasureTemplates (in maps/random/rmgen-common/player_DE.js).
• Change the function to either (or both)
  • not account for zero-cost resources.
  • fail/warn when no treasure template exist.
• Don't have standard cost of "0" for structures (not specified resources are already assumed "0", be aware that this might not be true for every piece of code).

These options can be mixed and matched.

[wowgetoffyourcellphone]

1 hour ago, Freagarach said:

• Don't have standard cost of "0" for structures (not specified resources are already assumed "0", be aware that this might not be true for every piece of code).

 

Thank you for parsing the issue. This is the solution I went with and it fixed the issue!

 

@anony5496 This will be fixed in the next release.

[anony5496]

2 hours ago, wowgetoffyourcellphone said:

Thank you for parsing the issue. This is the solution I went with and it fixed the issue!

 

@anony5496 This will be fixed in the next release.

Thank you so much! Will be looking forward to the next release then =)

[Lion.Kanzen]

Any request for icons?

@wowgetoffyourcellphone or improve some?

I'm with a terrible desire to draw especially humans body, hands, portraits (this takes time).

[wowgetoffyourcellphone]

Alpha 26 on mod.io coming soon: https://0ad.old.mod.io/delenda-est

File is uploaded, waiting for acceptance.

[Lion.Kanzen]

it would be nice to include mercenaries from DE to EA.

[wowgetoffyourcellphone]

10 hours ago, Lion.Kanzen said:

it would be nice to include mercenaries from DE to EA.

The entire concept or just some of the mercenary units?

[Lion.Kanzen]

41 minutes ago, wowgetoffyourcellphone said:

The entire concept or just some of the mercenary units?

first the mercenaries easy and then the mechanics of the camps.

[mine_turtle]

Hi all,

Is Delenda Est a multiplayer oriented mod only?

I find the Petra AI on very hard behaving like it is easy or very easy. Not bragging here. The AI does not develop it's structures almost at all - barracks, stables and some houses, minimal army and minimal civilian population only.

In my 1 vs 3 (Very Hard AI) game, they only respond to my attacks in groups of 2-5 infantry ... And I was the first to attack ?!? I like to turtle btw.

In the vanilla game (also 1 vs 3 VH AI) I played just before this one, AI mopped the floor with my behind in the second coordinated attack (zillions of infantry, javelins, cavalry followed up by battering rams, and some more infantry for good measure).

Is Petra AI unable to utilize the altered mechanics of Delenda Est properly? Or is there some special setting/mod I should consider adding on top?

Otherwise, the mod is very intuitive and looks fantastic.

 

Cheers

[wowgetoffyourcellphone]

Yeah, the AI needs modded as well, but that's beyond my current skillset.

 

I will say the current development version has the AI playing pretty well though, but still not as good as in vanilla.

 

Do you play random maps or skirmish maps in DE? Random maps don't have all of the features.

Edited May 2, 2023 by wowgetoffyourcellphone

[mine_turtle]

Regular existing maps so far.

Wish you all the best with further development of the mod.

[zozio32]

I tried it yesterday, single player mod, on very easy just to see the mechanics and be able to explore the concept without real challenge.

It is great!   I do like to coin and glory resource, it is nice to have the stall to "extend" the market, nice feature to have the priest worshipping at the statue. Tha additional units and tech are a nice addition, and specally the fact that you can't do them all, there is a choice, and they are not only "good"