Jump to content

GunChleoc

Community Members
  • Posts

    619
  • Joined

  • Last visited

  • Days Won

    5

Posts posted by GunChleoc

  1. 51 minutes ago, Anaxandridas ho Skandiates said:

    I am not offended that he does not agree, I am offended because I offered to help fix a major deficit in 0 A.D. hellenic factions a very, very long time ago.

     

    Well, this sounded like you were personally deeply offended

    Quote


    @Nescio claims it is an inferior standard and that it would be "a step back" - thereby he means of course also to signify that my knowledge and understanding of Greek is inferior since the proposer must surely be as inferior as his proposal.

     

    • Like 1
  2. There's a difference between creating a mod that will be your own game (what LordGood talked about) or creating a mod to test out changes aimed at vanilla more easily. I was talking about the latter.

    The same way, you can use a knife to kill someone, so knives are bad if you're a peaceful person. So, by your logic, if you're a peaceful person, you should never, ever use a knife under any circumstances and good luck with trying to cut a slice of bread.

    • Like 3
  3. I don't understand why you are so adamant against developing things in a mod before creating a patch. It allows players who don't know how to deal with SVN and patches to participate in the testing. Being a good tester is an entirely different skillset from being a good programmer.

    • Like 5
  4. 13 hours ago, elexis said:

    Problem is if one spends some time to give some valuable feedback, one gets implicated (i.e. one gets bad reputation if one provides some feedback for improvements but doesn't finish off with a complete review, test, discussion, commit, fixing bugs or balancing defects of that afterwards), so developers are often faced with the decision to not respond at all, to go all the way, or to appear as someone who orders someone to do additional work for no reason. I.e. one has to bring a lot of dedication and time if one wants to start working on something.

    I think that is indeed a problem. The responsibility of the reviewer should end with the commit and after that, the responsibility of maintaining the patch should lie with the person submitting the patch. Of course, people can also disappear, but being afraid of that will continue to be a huge blocker. People submitting a patch should state if they can't do the follow-up maintenance so that the team will know what to expect, and the team can of course not assume anything when there's a new contributor. I guess the thing here is to find a balanced way of dealing with the risk of new/regression bugs.

    • Like 1
  5. It could help if proposed patches were available as branches. This way, people who are a bit less techy but really good at testing and breaking stuff could help with that part of the review without having to learn how to apply patches, while people who know the code can look at the code itself. Going down this route has really helped us at Widelands - we have some people in our community who don't know any C++ but are really good at testing. This both increased the quality of the reviews and freed up developers' time.

    • Like 3
    • Thanks 1
  6. On 5/7/2019 at 9:07 AM, stanislas69 said:

    Well in this case according to the wiki we should use the american spelling and meaning.

    Agreed. This is also common practice for most software projects, and British English can always be added as a translation, as has been done on Transifex for 0 A.D.. The only project that I have come across so far that uses en_GB as a source language is phpBB, and I translate a lot of projects.

    • Like 1
    • Thanks 1
×
×
  • Create New...