Jump to content
Sign in to follow this  
wraitii

===[COMMITTED]=== Update gatherer actors to have idle-carry animations

Recommended Posts

1 hour ago, wraitii said:

As done in https://code.wildfiregames.com/rP20631, we should update all gatherer actors so that they can support having idle carrying animations.

This should/could be done incrementally, but in general I think a class of unit should be done across all civs at once.

Minor ranting :

Spoiler

 

I see you went for comments in XML files. I still think it would have been better to do something like :
 


  <group name="base_overload">
    <variant file="biped/female_base_walk.xml"/>
    <variant file="biped/female_carry_food.xml"/>
    <variant file="biped/female_carry_meat.xml"/>
    <variant file="biped/female_carry_wood.xml"/>
    <variant file="biped/female_carry_stone.xml"/>
    <variant file="biped/female_carry_metal.xml"/>
  </group>

instead of :


  <group>
    <!-- In this group, defined overloads for "Idle", "Walk" and "Run" -->
    <variant file="biped/female_base_walk.xml"/>
    <variant file="biped/female_carry_food.xml"/>
    <variant file="biped/female_carry_meat.xml"/>
    <variant file="biped/female_carry_wood.xml"/>
    <variant file="biped/female_carry_stone.xml"/>
    <variant file="biped/female_carry_metal.xml"/>
  </group>

 because it now means we have a lot of comments maintaining to do, while those could have been in the wiki. @leper

 

I'll add updating those actors to my list of tasks. It's a good occasion to clean up the actor files.

  • Like 1

Share this post


Link to post
Share on other sites

I don't think the comments necessarily need to be added to other files, tbh. They can be added to the wiki if you judge it necessary.

They're accurate anyhow and their presence or absence doesn't affect other files.

Share this post


Link to post
Share on other sites
On 12/10/2017 at 5:22 AM, wraitii said:

As done in https://code.wildfiregames.com/rP20631, we should update all gatherer actors so that they can support having idle carrying animations.

This should/could be done incrementally, but in general I think a class of unit should be done across all civs at once.

I look forward to this, because now the males look funny when shuttling resources. ;)

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

×
×
  • Create New...