wowgetoffyourcellphone Posted October 31, 2022 Report Share Posted October 31, 2022 (edited) https://code.wildfiregames.com/D4813 The above diff adds colors for players 9-18. Tweaks the colors for players 1-8 to help them stand out from the new colors. Adds a "ColorName" line for each for identification and possible future use. If anyone would like to try it and review, that would be great. Referenced diff: https://code.wildfiregames.com/D4811 Edited October 31, 2022 by wowgetoffyourcellphone 2 2 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted October 31, 2022 Author Report Share Posted October 31, 2022 1 Quote Link to comment Share on other sites More sharing options...
Ceres Posted October 31, 2022 Report Share Posted October 31, 2022 @wowgetoffyourcellphone How could I test this? I have already a git cloned version of 0 A.D. dev and a mixture of svn and git forked on my laptop (with my own changes), but I am missing experience about good practice for this to clone the right stuff for testing. Or should I fetch the whole code starting fresh via svn? What is the URL for this? Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted October 31, 2022 Author Report Share Posted October 31, 2022 1 minute ago, Ceres said: @wowgetoffyourcellphone How could I test this? I have already a git cloned version of 0 A.D. dev and a mixture of svn and git forked on my laptop (with my own changes), but I am missing experience about good practice for this to clone the right stuff for testing. Or should I fetch the whole code starting fresh via svn? What is the URL for this? You definitely should use SVN to apply the patch. It should work on whatever version of the game you have as long as it is after this commit: https://trac.wildfiregames.com/changeset/27172 After downloading the diff you double click it and if you have SVN installed a window similar to this should pop up, and you choose Apply Patch... You have to choose the root folder of the 0 A.D. installation and apply all the changes. It takes some trial and error for someone new to handling diffs, but once you got it it's very simple. 2 Quote Link to comment Share on other sites More sharing options...
Ceres Posted October 31, 2022 Report Share Posted October 31, 2022 (edited) @wowgetoffyourcellphone I am on 27187 (a fresh svn co https://svn.wildfiregames.com/public/ps/trunk/ 0ad-svn), DLed the D4811.diff file, and double-clicked on it. After trying to apply the patch via TortoiseSVN on my 0ad-svn folder, I get the message that it could not be cleanly applied (and the process was stopped). Which folder do I have to select after clicking on "Apply Patch..." in TortoiseSVN? Thank you! Edited October 31, 2022 by Ceres Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted October 31, 2022 Author Report Share Posted October 31, 2022 8 minutes ago, Ceres said: @wowgetoffyourcellphone Which folder do I have to select after clicking on "Apply Patch..." in TortoiseSVN? Thank you! Usually the folder above binaries. Quote Link to comment Share on other sites More sharing options...
Ceres Posted October 31, 2022 Report Share Posted October 31, 2022 (edited) @wowgetoffyourcellphone It does not work like this for me, but after I started TortoiseSVN and applied to patch from its main window, it started searching for a "more appropriate" path - and found it. And I see a confirmation that 14 files have been added: Now how do I test this in 0ad? Wouldn't we need a match for more than 8 players? If yes, the maximum number of players I find matching maps for, is eight. Have I misunderstood you in some way? Sorry about this and thanks for your patience with me! EDIT: Sorry again, but TortoiseSVN placed the files ion the wrong place: I first have to get this right (but my question about the numbers of players and appropriate map remains valid). EDIT: Since I do not want to further clutter your thread about your new colouring scheme with my technical questions about applying a patch, I have started a new thread for this. So this thread here should only be further used for @wowgetoffyourcellphone's new patch. Edited October 31, 2022 by Ceres Quote Link to comment Share on other sites More sharing options...
Ceres Posted October 31, 2022 Report Share Posted October 31, 2022 @wowgetoffyourcellphone Very nice indeed: Have you seen this comment? @vladislavbelov wrote: Quote The diff might have a serious flaw: there is a code depending on the number of entries in that file. ColorName isn't translated. Also not sure how find*UnusedColor would behave for that. Quote Link to comment Share on other sites More sharing options...
Lion.Kanzen Posted October 31, 2022 Report Share Posted October 31, 2022 you did not include (french) fucsia? #FD3F92 https://en.m.wikipedia.org/wiki/Fuchsia_(color) Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted October 31, 2022 Author Report Share Posted October 31, 2022 (edited) 1 hour ago, Lion.Kanzen said: you did not include (french) fucsia? #FD3F92 https://en.m.wikipedia.org/wiki/Fuchsia_(color) One iteration did include Fuchsia at one point, but decided to split it into Tyrian purple and pink. Edited October 31, 2022 by wowgetoffyourcellphone Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted October 31, 2022 Author Report Share Posted October 31, 2022 (edited) 1 hour ago, Ceres said: I wish the swatches (the colored squares) were bigger. I'm not sure which file controls that though. Edited October 31, 2022 by wowgetoffyourcellphone Quote Link to comment Share on other sites More sharing options...
sarcoma Posted October 31, 2022 Report Share Posted October 31, 2022 (edited) 4 hours ago, Ceres said: How could I test this? I have already a git cloned version of 0 A.D. dev and a mixture of svn and git forked on my laptop (with my own Edit: better way patch -p0 < patch.diff Edited October 31, 2022 by sarcoma 1 1 Quote Link to comment Share on other sites More sharing options...
GrimPixel Posted October 31, 2022 Report Share Posted October 31, 2022 There is someone who made some choices: https://sashamaps.net/docs/resources/20-colors/ Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted October 31, 2022 Author Report Share Posted October 31, 2022 1 hour ago, GrimPixel said: There is someone who made some choices: https://sashamaps.net/docs/resources/20-colors/ Yep. In my research I came across that site. This one here is really awesome for coming up with differentiated color palettes: https://mokole.com/palette.html. The colors that are in the current patch for the most part came from playing around with the feature on that site. Quote Link to comment Share on other sites More sharing options...
Darkcity Posted November 1, 2022 Report Share Posted November 1, 2022 (edited) 11 hours ago, Ceres said: Very nice indeed: Have you seen this comment? @vladislavbelov wrote: Can we change the UI for color selection? From vertical line to some square format (4x4 grid) just like any other UI. @wowgetoffyourcellphone CC: @rossenburg for your mod as well. Edited November 1, 2022 by Darkcity 1 Quote Link to comment Share on other sites More sharing options...
GrimPixel Posted November 1, 2022 Report Share Posted November 1, 2022 (edited) 5 hours ago, Darkcity said: Can we change the UI for color selection? From vertical line to some square format (4x4 grid) just like any other UI. @wowgetoffyourcellphone CC: @rossenburg for your mod as well. Yes, I think the colour selection dropdown can be in palette shape like this, with gradual changes for nearby colours: Edited November 1, 2022 by GrimPixel Quote Link to comment Share on other sites More sharing options...
Ceres Posted November 1, 2022 Report Share Posted November 1, 2022 Since I play 0AD not online I may have missed a lot, but I wonder in which scenario can we have more than 8 players? There's 1 map for 8 players that I found, but as I said, my experience with online and thus many players is null. Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted November 1, 2022 Author Report Share Posted November 1, 2022 4 hours ago, Ceres said: Since I play 0AD not online I may have missed a lot, but I wonder in which scenario can we have more than 8 players? There's 1 map for 8 players that I found, but as I said, my experience with online and thus many players is null. The colors are only called "Player 9" - "Player 16", but only to keep the original pattern. Not sure if they can be called anything else. The patch is to give more choice of colors, not more choice of number of players. The max players is still 8. 1 1 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted November 1, 2022 Author Report Share Posted November 1, 2022 8 hours ago, Darkcity said: Can we change the UI for color selection? From vertical line to some square format (4x4 grid) just like any other UI. @wowgetoffyourcellphone CC: @rossenburg for your mod as well. 8 hours ago, GrimPixel said: Yes, I think the colour selection dropdown can be in palette shape like this, with gradual changes for nearby colours: I agree that a bigger drop down would be nice indeed. Hopefully someone else can make a patch, as I wouldn't know how to make this for you. Quote Link to comment Share on other sites More sharing options...
Darkcity Posted November 1, 2022 Report Share Posted November 1, 2022 2 hours ago, wowgetoffyourcellphone said: I wouldn't know how to make this for you. Make it for the community . I think @rossenburgwould be able to help in making the same. He is working on enhanced UI mod for 0ad. 2 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.