Introducing the Official community mod for Alpha 26

[Norse_Harold]

Just now, real_tabasco_sauce said:

Were you in multiplayer? The crashes only seem to happen in multiplayer with a player opponent or spectator.

I was not in multiplayer, but if my theory is correct that excessive destroy calls on the same entity are the cause of the crash then it's a useful line of investigation.

[real_tabasco_sauce]

Well, we could just scrap the 'walls delete trees' for the time being.

[Norse_Harold]

3 minutes ago, real_tabasco_sauce said:

Well, we could just scrap the 'walls delete trees' for the time being.

Yes, we could, although I would like that it be made into a separate mod so that people can do testing and development of it.

[Norse_Harold]

This discussion about the bug in the 'walls delete trees' feature was probably better done in an issue on the Gitea repository 0ad-community-mod-a26. Next time...

Edited September 10 by Norse_Harold

[real_tabasco_sauce]

5 minutes ago, Norse_Harold said:

Yes, we could, although I would like that it be made into a separate mod so that people can do testing and development of it.

@Grapjas made the original:

https://wildfiregames.com/forum/topic/18003-suggestions-for-0-ad/?do=findComment&comment=579557

[Stan`]

I haven't looked at the code. But the crash is due to something not being serializable (the serialization error from above). Could be a NaN value for instance from the error it seems total builder is NaN

 

[real_tabasco_sauce]

Ok I can confirm it only seemed like a roman thing because lots of ppl were playing romans. I just reproduced it with other civs.

[Stan`]

18 minutes ago, real_tabasco_sauce said:

Ok I can confirm it only seemed like a roman thing because lots of ppl were playing romans. I just reproduced it with other civs.

Did you find a consistent way to reproduce it ?

[real_tabasco_sauce]

the best way to do it is just to get in a 1v1, don't use gift from the gods, and start building a lot of buildings.

I can't reproduce it by building any specific building in any specific place, I just build until it crashes.

[real_tabasco_sauce]

community-testing-5.zip

these changes add @Norse_Harold's above suggestion to prevent entities from being deleted more than once, and includes the changes to only return false; if the building is not a wall or palisade.

This prevented any crashes until we started building walls. We did a game where we only placed walls on completely bare ground, completely avoiding trees and decorative entities, and the crash still occurred.

Edited September 10 by real_tabasco_sauce

[Norse_Harold]

1 hour ago, real_tabasco_sauce said:

This prevented any crashes until we started building walls. We did a game where we only placed walls on completely bare ground, completely avoiding trees and decorative entities, and the crash still occurred.

Good idea to run that test. That's interesting that the crash still occurred. I advise separating the walls delete trees mod from the rest of community-mod for further testing, so that a binary search algorithm can be applied where the search space is cut in half with each iteration.

If the problem is then found to be correlated with the walls delete trees mod then here are some things to consider.

• Normally (invisible or less visible) obstructions would be destroyed before the foundation is committed instead of after it's finished.
• Maybe isFinished isn't called after every structure is completely constructed. In that case, obstructing entities aren't destroyed.
• Units blocking construction might conflict with or be locked into the structure if return false isn't present on line 275 of Foundation.js.

Edited September 10 by Norse_Harold

[real_tabasco_sauce]

recently, I tried another conditional return, only when totalBuildRate was NaN. This didn't help, because totalBuildRate presumably becomes NaN after commit().

			if (isNaN(this.totalBuilderRate)) {
				warn("Value of builder rate is NaN");
				return false;
			}

I wonder if there is something we can check instead of totalBuildRate that will return false when we want it to.

Maybe EntstoDestroy being empty or something else?

Edited September 10 by real_tabasco_sauce

[Stan`]

Somewhere somehow you're doing an operation where you do undefined + number or null + number or nan + number or sometimes string + number

[real_tabasco_sauce]

I'm inclined to think that this was a pre-existing error that was just uncovered by the building on trees mod. Maybe some amount of buildings had this issue, but the return false; was catching them.

[Norse_Harold]

In my opinion, way too much is being tested at once, considering that all of community-mod is also in the test case. Therefore the cause could be anywhere. Why assume that it's caused by the walls delete trees component unless the crash can be reproduced with only that component?

[Grapjas]

Well, as i said it was more of a prototype code and expected someone to build off of it .

As for entsToDestroy, it doesn't need to be cleaned or emptied because a foundation will just start with an empty variable to begin with and be gone when the foundation has been built.

The new zip below has some fun JS edge case (also why are empty arrays truthy ) going on where it pushes ent twice, not really an issue but it shouldn't regardless.

Also got the shading to mark entities red that would be destroyed semi working aswell (not in this zip tho) but i've honestly got to much projects going on to finish it anytime soon lol.

Lemme know if this one's better and tweak it as you need.

BTW, can't you simply delete my mod (or files) to test if it still happens without?

walls_destroy_trees.zip

Edited September 10 by Grapjas

[Norse_Harold]

4 minutes ago, Grapjas said:

As for entsToDestroy, it doesn't need to be cleaned or emptied because a foundation will just start with an empty variable to begin with and be gone when the foundation has been built.

I think that isFinished() can be called multiple times when build progress is 1.0, so entsToDestroy is being processed multiple times. I've confirmed this with testing.

[Grapjas]

21 minutes ago, Norse_Harold said:

I think that isFinished() can be called multiple times when build progress is 1.0, so entsToDestroy is being processed multiple times. I've confirmed this with testing.

It gets called alot throughout when the foundation is being built, but the statement should still only run once. Maybe twice, but engine.DestroyEntity does nothing gamebreaking if the ent doesn't exist anyway otherwise i'd expect it to throw an error.

EDIT: you are right the var should be emptied if it does called multiple times though

Edited September 10 by Grapjas

[real_tabasco_sauce]

version 12 is out with no crashes (so far)!

[Grapjas]

36 minutes ago, real_tabasco_sauce said:

version 12 is out with no crashes (so far)!

Hmm so it was the walls over trees mod? Interesting.

[real_tabasco_sauce]

yes, and it seems to be fixed in your recent mod.

[real_tabasco_sauce]

Ok, there have been issues with OOS in the new version of the community mod. It seems many of these are related to install issues with version 12:

For example:

<p class="warning">WARNING: Technology "phase_town_spart" does not exist</p>

In this case, a version 10 file called "phase_town_spart" remains after installing version 12, which is supposed to be deleted in version 12.

How to fix (and hopefully this solves the OOS for good).

1. uninstall all your mods
2. navigate to your mods folder (For example, windows might be C:/Documents/My\ Games/0ad/mods/
3. delete the community mod folder
4. open 0ad and re-install the community mod and your other mods.