Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 Well I suppose that's because gather_grain is missing from all of them --' 1 Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 But I guess that isn't intended? Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 Just now, maroder said: But I guess that isn't intended? No there have been so many changes in the mod that I can't keep track. Some of them were good and the others were pretty weird or bad. 1 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted September 14, 2021 Report Share Posted September 14, 2021 21 minutes ago, Stan` said: No there have been so many changes in the mod that I can't keep track. Some of them were good and the others were pretty weird or bad. Isn't that your working copy? XD Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 Other people have access now... Quote Link to comment Share on other sites More sharing options...
Ceres Posted September 14, 2021 Report Share Posted September 14, 2021 Where? Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 31 minutes ago, Stan` said: Some of them were good and the others were pretty weird or bad. Isn't that the reason for the git-flow and branch logic? Nothing makes it into the main branch without review. @Ceres the github repo: https://github.com/0ADMods/han_china 1 Quote Link to comment Share on other sites More sharing options...
Ceres Posted September 14, 2021 Report Share Posted September 14, 2021 (edited) Ok, that's the one I had looked into, so I was on the right path. Edited September 14, 2021 by Ceres Quote Link to comment Share on other sites More sharing options...
hyperion Posted September 14, 2021 Report Share Posted September 14, 2021 10 minutes ago, maroder said: Isn't that the reason for the git-flow and branch logic? Nothing makes it into the main branch without review. To used to to svn 1 Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 22 minutes ago, maroder said: Nothing makes it into the main branch without review. That's the keyword. I didn't review those changes. Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 4 minutes ago, Stan` said: That's the keyword. I didn't review those changes. Yeah, thought so. but maybe you just need to tell everybody that they can commit all the changes they want to their own branch, but that the main branch is restricted. Github even has that as a nice feature: protected branches Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 Well yeah. I tend to trust people. But I shouldn't. I hoped stuff could work without micromanagement. 1 Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 47 minutes ago, Stan` said: But I shouldn't. Nah, that's a good trait, you should. But that's no reason not to have a system that can minimize possible mistakes. But yes some kind of micromanagement is always necessary I guess. Possibly something you could delegate? I.e some form of community reviews. Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 So by trusting people ? 1 Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 (edited) Yeah, but spread the trust between many people. Checks and balances. Nothing gets committed (to main) without review of someone. More eyes are always better. Edited September 14, 2021 by maroder 1 Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 44 minutes ago, maroder said: Checks and balances. Nothing gets committed (to main) without review of someone. More eyes are always better Find me the people and I'm down Quote Link to comment Share on other sites More sharing options...
Ceres Posted September 14, 2021 Report Share Posted September 14, 2021 Divide et impera! Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 6 minutes ago, Ceres said: Divide et impera! I thought that was for your enemies? Here I'm trying to build something :p 1 Quote Link to comment Share on other sites More sharing options...
Ceres Posted September 14, 2021 Report Share Posted September 14, 2021 Not Han dynasty, but maybe nevertheless inspiring: A Brief Introduction to Ancient Chinese Military Weapons https://www.viewofchina.com/ancient-chinese-military-weapons/ Quote Link to comment Share on other sites More sharing options...
hyperion Posted September 14, 2021 Report Share Posted September 14, 2021 4 hours ago, Stan` said: Well yeah. I tend to trust people. But I shouldn't. I hoped stuff could work without micromanagement. Trusting people to try their best is certainly good. Trusting people are born fully fledged coders and knowledgeable of the ins and outs of the project is bound to not work. The first thing about git is branches are very cheap, commits are very cheap. To test or review I don't need anything committed to master to reduce workload, so there is no need to commit anything to master either. At one point you will have to look at what was done either way, so commits to master can't reduce your workload only increase it unless you don't care about the master branch in the first place. Anyway good to run into such issues now, so you can ponder a workflow for in case of migration. 1 Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 (edited) 2 hours ago, Stan` said: Find me the people and I'm down I know, easier said than done. But I think in the case of this mod (without custom code), everybody who wants the Han included or who already contributed qualifies. It's more about getting a more "formal" system to not only commit stuff, but also review the stuff other people committed, before it gets included. Even if its not a full review, but just play-testing, this will decrease the amount of bugs that can be introduced. Cause without a more formal system you find bugs only by accident. An of course when talking about the complete git migration, there has to be a different workflow and completely different level and quality of reviews. Edited September 14, 2021 by maroder Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 14, 2021 Report Share Posted September 14, 2021 1 hour ago, hyperion said: Anyway good to run into such issues now, so you can ponder a workflow for in case of migration. Indeed it's nice to run into it now, however the bar for mods has always been lower than the main game. 1 hour ago, hyperion said: Trusting people to try their best is certainly good. Trusting people are born fully fledged coders and knowledgeable of the ins and outs of the project is bound to not work. Of course. And then we (or I in that matter) will have to teach them and then you get at the point where it's tempting to do everything yourself because you know you're gonna be there tomorrow and it might faster to do things yourself. I hate doing that and I I believe mistakes are good for learning. But sometimes it backfires 1 hour ago, maroder said: It's more about getting a more "formal" system to not only commit stuff, but also review the stuff other people committed, before it gets included. Even if its not a full review, but just play-testing, this will decrease the amount of bugs that can be introduced. You need someone with the committment to test. It might take months before that happen. Which can be fine, but also an extremely confusing / frustrating experience. Quote Link to comment Share on other sites More sharing options...
hyperion Posted September 14, 2021 Report Share Posted September 14, 2021 34 minutes ago, Stan` said: Of course. And then we (or I in that matter) will have to teach them and then you get at the point where it's tempting to do everything yourself because you know you're gonna be there tomorrow and it might faster to do things yourself. I hate doing that and I I believe mistakes are good for learning. But sometimes it backfires Of course contributors are more of an investment than getting things done quickly. Experienced opensource coders are not the norm. But there is no need for hand holding either, which you tend to fall into all to quickly. Quote Link to comment Share on other sites More sharing options...
MoLAoS Posted September 14, 2021 Report Share Posted September 14, 2021 11 hours ago, ymming said: The application would more be like tomahawk. This is good. Maybe a uniqueish Han trait is their throwy boys are a little shorter range but their archyboys are a little longer range thanks to crossbows. It appears they definitely lacked slings though. Even the literal slingers.com forums couldn't fine pre 900AD sling. Quote Link to comment Share on other sites More sharing options...
maroder Posted September 14, 2021 Report Share Posted September 14, 2021 1 hour ago, Stan` said: you get at the point where it's tempting to do everything yourself The perks of maintaining an open source project But the teaching aspect is very good for building a community. 1 hour ago, Stan` said: You need someone with the committment to test. It might take months before that happen. Which can be fine, but also an extremely confusing / frustrating experience. True I guess. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.