Freagarach Posted June 8, 2019 Report Share Posted June 8, 2019 On 08/06/2019 at 3:39 PM, wowgetoffyourcellphone said: I didn't mean that the code should be hacky. I meant that something doesn't have to be feature complete in one patch. It can be broken down into usable chunks. For instance, making captured horses commandable is useful on it's own. Making them garrisonable can be another patch. Expand I understand that you did not mean that code should hacky, my choice of words was off, sorry about that. I meant that if something is expandable, the dev's usually want that done as well (D1960) 1 Quote Link to comment Share on other sites More sharing options...
Freagarach Posted June 8, 2019 Report Share Posted June 8, 2019 On 07/06/2019 at 5:31 AM, wowgetoffyourcellphone said: To make them garrisonable in corrals requires some other line changes, but those could be a different patch if necessary Expand (D1961) 1 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted June 30, 2019 Author Report Share Posted June 30, 2019 On 12/05/2019 at 12:00 PM, wowgetoffyourcellphone said: I have 1 curious bug. When the horse wanders it walks at a normal pace (the animation seems to play at the prescribed speed in the variant file). But when I, the player, tasks the horse the actor plays the walk animation at a higher speed (the entity's walkspeed does not change in either case). Expand On 12/05/2019 at 6:49 PM, Angen said: Thank you for report. Possible problem has been identified Expand On 16/05/2019 at 6:09 AM, Stan` said: Yeah it should be fixed when @wraitii commits his patches Expand 1 Quote Link to comment Share on other sites More sharing options...
Silier Posted June 30, 2019 Report Share Posted June 30, 2019 (edited) Hi @wowgetoffyourcellphone Please see https://code.wildfiregames.com/rP22197#inline-3121 That is cause animal walks differently. I am not sure with which patch is @wraitii going to fix it but he will eventually Anyway I think it would need to be edited animation speed in actors after that change. Edited June 30, 2019 by Angen 1 1 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted July 2, 2019 Author Report Share Posted July 2, 2019 On 12/05/2019 at 11:13 AM, Freagarach said: True. I just tested it and it ensures that every animal under my control can be given orders. Thus addressing your question, I guess. Have you tried it yourself yet? Reveal hidden contents In the UnitAI.js Lines 195, 267, 295, 321 : remove "this.IsAnimal() && !this.IsDomestic() || " Remove lines 246 to 252 I hope this is clear and works for you! Expand After the latest svn changes to UnitAI and reapplying your suggested changes, it no longer works. No player controlled animals can move, not even domestic. Can you advise? Quote Link to comment Share on other sites More sharing options...
Freagarach Posted July 2, 2019 Report Share Posted July 2, 2019 (edited) On 02/07/2019 at 5:44 AM, wowgetoffyourcellphone said: After the latest svn changes to UnitAI and reapplying your suggested changes, it no longer works. No player controlled animals can move, not even domestic. Can you advise? Expand Strange, I cannot reproduce that. Did you rebuild? Reveal hidden contents The lines are now: - Lines 191, 258, 282, 307 : remove "this.IsAnimal() && !this.IsDomestic() || " . - Remove lines 237 to 243 and 450 to 455. But I guess yours may be different. Is the updated "UnitAI.js" on your DE-git? Because I see in that file that `!this.IsDomestic()` is removed but the `this.IsAnimal` is still there? Edit: You can see in D1960 how the code should look like. Edited July 2, 2019 by Freagarach Link. 1 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted July 3, 2019 Author Report Share Posted July 3, 2019 On 02/07/2019 at 4:06 PM, Freagarach said: Strange, I cannot reproduce that. Did you rebuild? Reveal hidden contents The lines are now: - Lines 191, 258, 282, 307 : remove "this.IsAnimal() && !this.IsDomestic() || " . - Remove lines 237 to 243 and 450 to 455. But I guess yours may be different. Is the updated "UnitAI.js" on your DE-git? Because I see in that file that `!this.IsDomestic()` is removed but the `this.IsAnimal` is still there? Edit: You can see in D1960 how the code should look like. Expand Thanks. Worked. 2 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted July 24, 2019 Author Report Share Posted July 24, 2019 @Freagarach is there a diff for garrisoning animals? Quote Link to comment Share on other sites More sharing options...
Silier Posted July 24, 2019 Report Share Posted July 24, 2019 @wowgetoffyourcellphone https://code.wildfiregames.com/D1961 @Freagarach has some problems with laptop charging currently Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted July 24, 2019 Author Report Share Posted July 24, 2019 On 24/07/2019 at 5:32 PM, Angen said: @wowgetoffyourcellphone https://code.wildfiregames.com/D1961 @Freagarach has some problems with laptop charging currently Expand Looks like it needs rebased. Quote Link to comment Share on other sites More sharing options...
Freagarach Posted July 25, 2019 Report Share Posted July 25, 2019 On 24/07/2019 at 9:37 PM, wowgetoffyourcellphone said: Looks like it needs rebased. Expand Propably, but there is no point when a review is not close yet. On 24/07/2019 at 5:32 PM, Angen said: @wowgetoffyourcellphone https://code.wildfiregames.com/D1961 @Freagarach has some problems with laptop charging currently Expand Thanks for the pointing! I should be back on track after the weekend. Quote Link to comment Share on other sites More sharing options...
Freagarach Posted November 9, 2020 Report Share Posted November 9, 2020 (Controllability patch is committed ) 1 Quote Link to comment Share on other sites More sharing options...
wowgetoffyourcellphone Posted November 9, 2020 Author Report Share Posted November 9, 2020 On 09/11/2020 at 8:40 AM, Freagarach said: (Controllability patch is committed ) Expand You mean I don't have to maintain UnitAI.js anymore??? Oh... I forgot edit cheering length too. lol Quote Link to comment Share on other sites More sharing options...
Stan` Posted November 16, 2020 Report Share Posted November 16, 2020 On 09/11/2020 at 4:06 PM, wowgetoffyourcellphone said: Oh... I forgot edit cheering length too. lol Expand You can just edit template_unit now 2 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.