[R26472] Diplomacy menu broken + (Use friendly territory+ Friendly vision icons switched)

[Purgator_]

Latest SVN version.

Opening Diplomacy menu causes an error, resulting in the following log:

 

Edited February 23, 2022 by Purgator_

[Purgator_]

Also those 2 icons are swapped. Friendly vision icon says it costs wood+food+stone+metal, while Use friendly territory costs food+metal. Someone swapped places for those icons ^^

[Silier]

1 hour ago, Purgator_ said:

Also those 2 icons are swapped. Friendly vision icon says it costs wood+food+stone+metal, while Use friendly territory costs food+metal. Someone swapped places for those icons ^^

yeah, noticed
https://code.wildfiregames.com/rP26470

[Silier]

1 hour ago, Purgator_ said:

Opening Diplomacy menu causes an error, resulting in the following log:

in the process https://code.wildfiregames.com/D4503

[wowgetoffyourcellphone]

4 hours ago, Silier said:

yeah, noticed
https://code.wildfiregames.com/rP26470

I switched them because a bird carrying a branch made no sense to represent "Cartography." The map icon makes 10x more sense. I can change it back, but it's getting really irritating how every minor art change is being nitpicked.

[Lion.Kanzen]

3 hours ago, wowgetoffyourcellphone said:

I switched them because a bird carrying a branch made no sense to represent "Cartography." The map icon makes 10x more sense. I can change it back, but it's getting really irritating how every minor art change is being nitpicked.

We've gotten used to them in several alphas.

[Freagarach]

1 hour ago, Lion.Kanzen said:

We've gotten used to them in several alphas.

^ That, @wowgetoffyourcellphone. The change itself may be not bad, but there are thousands of users (okay, just a lot) that rely on only the icon. (Also the map has the arrows representing diaspora.)

[Lion.Kanzen]

27 minutes ago, Freagarach said:

^ That, @wowgetoffyourcellphone. The change itself may be not bad, but there are thousands of users (okay, just a lot) that rely on only the icon. (Also the map has the arrows representing diaspora.)

time to make some new map.... Icon in this case.

Edited February 24, 2022 by Lion.Kanzen
clarification

[wowgetoffyourcellphone]

Guys, there are several things that people are "used to" that are changed every alpha. Also, should we not improve or fix things just because people are used to them being broken or poor?  I think in this case, the major issue is actually that the portraits are simply switched, rather than completely changed. Simply switching them as I did does indeed cause unnecessary confusion.