lobby WARNING!!!

[gameboy]

When selecting the "Set message of the day and send to online users" as a lobby moderator in option in pidgin, the following JS error occurs with alpha 22:

WARNING: JavaScript warning: gui/lobby/lobby.js line 232
reference to undefined property msg.from
WARNING: JavaScript warning: gui/lobby/lobby.js line 232
Script value conversion check failed: v.isString() || v.isNumber() (got type undefined)

[Stan`]

@elexis @fcxSanya

[fatherbushido]

https://trac.wildfiregames.com/ticket/4688

[gameboy]

But the problem still seems to exist, and I tested the latest SVN19968.

[fatherbushido]

Yes, it's a known problem reported in the ticket above.

[gameboy]

@elexis @fcxSanya

[elexis]

That what fatherbushido said. In addition it seems that other messages can trigger it too, because I didn't send such a message today (nor some time ago when this was reported in irc). I had that error few days ago but not today, so can't find out which comment we should add to the easy fix.

[gameboy]

Can this problem be fixed, my friend?

[gameboy]

@elexis

[Loki1950]

He has mentioned that it is an intermittent bug (he can not reproduce it ) and they are the hardest bugs to fix as they seem random the only solution is time so back off and give him that time bugs can not be fixed as soon as they show up they need analysis not demands.

Enjoy the Choice  

[gameboy]

@fcxSanya

[elexis]

gameboy, when exactly do you get the error?

[gameboy]

Yesterday, I tested it and got these warnings.

[gameboy]

@elexis

[elexis]

When you tested what exactly?

Wildfire Games svn lobby or your own lobby?

When creating a new account or when logging in with an existing account?

[gameboy]

@elexiswhen logging in with an existing account.

Wildfire Games svn lobby.

 

I tested it today.

[elexis]

That's weird, I never get it when logging in with an existing account in alpha 22 or svn.

Does anyone else get these warnings in that case?

gameboy, you get it on every login?

If so, try please try this patch and post the warning log or screenshot:

lobby_debug.patch

[gameboy]

@elexisyes, i get it on every login.

 

 

[elexis]

16 minutes ago, gameboy said:

@elexisyes, i get it on every login.

Ok, that's good so far!

@gameboy can you test this patch and give the output?

Quote

Index: binaries/data/mods/public/gui/lobby/lobby.js
===================================================================
--- binaries/data/mods/public/gui/lobby/lobby.js    (revision 19985)
+++ binaries/data/mods/public/gui/lobby/lobby.js    (working copy)
@@ -227,10 +227,11 @@ var g_NetMessageTypes = {
                 "text": escapeText(msg.text),
                 "time": msg.time
             });
         },
         "private-message": msg => {
+            warn(uneval(msg));
             if (Engine.LobbyGetPlayerRole(msg.from) == "moderator")
                 // some XMPP clients send trailing whitespace
                 addChatMessage({
                     "from": escapeText(msg.from),
                     "text": escapeText(msg.text.trim()),

 

[gameboy]

@elexisOK,  I used the patch you provided, and I got the warning message. I sent the message to the online user via pidgin.

WARNING: ({type:"chat", text:"hello", level:"private-message", time:1503030232})

WARNING: JavaScript warning: gui/lobby/lobby.js line 233 reference to undefined property msg.from

WARNING: JavaScript warning: gui/lobby/lobby.js line 233 Script value conversion check failed: v.isString() || v.isNumber() (got type undefined)

Engine exited successfully on 2017-08-18 at 12:24:16 with 620 message(s), 0 error(s) and 3 warning(s).

[elexis]

Okay thanks.

@gameboy How did you send the "hello" message in pidgin? Which button did you press exactly in pidgin?

You sent it only once in pidgin but get the error on each login?

[gameboy]

@elexisI click the button in Pidgin to 'send the message to all users online'.

yes,my friend.  I sent it only once in pidgin but get the error on each login.

[elexis]

Posted  something in the  ticket .

@gameboy  do you mean "message of the day" or "announcement" with "send the message to all users online"?

Can you try this?

1. apply the  warn(uneval(msg)); patch above

2. Send a pidgin message "Not hello"

3. Join lobby with 0AD and post the warnings to the forums.

4. Repeat step 3 two times
 

[gameboy]

@elexisI send the message to all users online.

1.yes,I used this patch.

2.I have sent the message through pidgin:"Not hello".

The same warning again: WARNING: ({type:"chat", text:"not hello", level:"private-message", time:1503030232})

 

 

Edited August 18, 2017 by gameboy

[elexis]

@gameboy  which message did you send in pidgin? "announcement" or "message of the day"?

Please send "not hello" in pidgin.

Check whether you still get "hello" in 0ad.