Introducing the Official community mod for Alpha 26

[Gurken Khan]

On 01/09/2024 at 1:14 AM, wowgetoffyourcellphone said:

Hopefully tree-destruction feature will prompt someone to make it more full-featured visually, by making the trees and shrubs tint red when the wall preview is waved over them. It's something I've wanted for a long time for Delenda Est, which allows all buildings to destroy trees when placed. 

btw I'd also like cadavers to be tinted if you wave a foundation over them, so that it's clear if a building buries that food source.

[wowgetoffyourcellphone]

4 hours ago, Gurken Khan said:

btw I'd also like cadavers to be tinted if you wave a foundation over them, so that it's clear if a building buries that food source.

Yep! The feature would be useful even without anything else.

[real_tabasco_sauce]

Ok, the new version is out!

[Philip the Swaggerless]

I heard romans are bugged now and the game crashes but it just crashed with persia vs hans

[Norse_Harold]

Some users have reported that the game crashes with community-mod version 0.26.11. They pasted relevant mainlog.html excerpts in the lobby.

according to Atrik_III:

Quote

ERROR: Script component Foundation of entity 6054 failed to serialize: Serialize_InvalidScriptValue
Serializing:
({committed:true, builders:{}, totalBuilderRate:NaN, buildMultiplier:0.7192230933248641, buildTimeModifier:0.7, previewEntity:536871097, finalTemplateName:"structures/rome/house", costs:{food:0, metal:0, stone:0, wood:150}, maxProgress:0.15906241386480338, initialised:true, entsToDestroy:[]})
terminate called after throwing an instance of 'PSERROR_Serialize_InvalidScriptValue'
  what():  Serialize_InvalidScriptValue

 

according to sanafur:
 

Quote

<p>Net client: Received message CEndCommandBatchMessage { m_Turn: 1140, m_TurnLength: 200 } of size 9 from server</p>
<p class="error">ERROR: Cannot serialize NaN values.</p>
<p class="error">ERROR: Script component Foundation of entity 6054 failed to serialize: Serialize_InvalidScriptValue
Serializing:
({committed:true, builders:{}, totalBuilderRate:NaN, buildMultiplier:0.7192230933248641, buildTimeModifier:0.7, previewEntity:536871023, finalTemplateName:"structures/rome/house", costs:{food:0, metal:0, stone:0, wood:150}, maxProgress:0.15906241386480338, initialised:true, entsToDestroy:[]})</p>

 

I would advise checking variables that affect the building rate. To determine which variables those are, see Foundation.js.

[Philip the Swaggerless]

yes i couldn't make it past p1 in multiplayer with various civs

[Norse_Harold]

2 minutes ago, Philip the Swaggerless said:

yes i couldn't make it past p1 in multiplayer with various civs

Can you search your logs for lines containing NaN and paste them, as well as surrounding lines for context? Sanafur's excerpt is optimal

Edited September 9 by Norse_Harold

[Philip the Swaggerless]

10 minutes ago, Norse_Harold said:

Can you search your logs for lines containing NaN and paste them, as well as surrounding lines for context? Sanafur's excerpt is optimal

Unfortunately I already restarted and played new games, so I don't have the log

[Philip the Swaggerless]

Happened again.  Should I also send crashlog.dmp?

 

CrashLog:

Details: unhandled exception (PSERROR_Serialize_InvalidScriptValue("Serialize_InvalidScriptValue"))

Location: unknown:0 (RtlGetAppContainerNamedObjectPath)

Call stack:

(error while dumping stack: No stack frames found)
errno = 0 (No error reported here)
OS error = 0 (no error code was set)

Not sure how much is relevant but here you go:

Net client: Received message CEndCommandBatchMessage { m_Turn: 410, m_TurnLength: 200 } of size 9 from server

Net client: Received message CSimulationMessage { m_Client: 2, m_Player: 2, m_Turn: 412, m_Data: ({type:"set-rallypoint", entities:[191], x:537.720458984375, z:1051.2384033203125, data:{command:"walk"}, queued:false}) } of size 161 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 411, m_TurnLength: 200 } of size 9 from server

Net client: Received message CSimulationMessage { m_Client: 2, m_Player: 2, m_Turn: 413, m_Data: ({type:"set-rallypoint", entities:[191], x:543.7225341796875, z:1050.23046875, data:{command:"walk"}, queued:false}) } of size 161 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 412, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 413, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 414, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 415, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 416, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 417, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 418, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 419, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 420, m_TurnLength: 200 } of size 9 from server

Net client: Received message CEndCommandBatchMessage { m_Turn: 421, m_TurnLength: 200 } of size 9 from server

ERROR: Cannot serialize NaN values.

ERROR: Script component Foundation of entity 6630 failed to serialize: Serialize_InvalidScriptValue Serializing: ({committed:true, builders:{}, totalBuilderRate:NaN, buildMultiplier:1, buildTimeModifier:0.7, previewEntity:536870967, finalTemplateName:"structures/rome/farmstead", costs:{food:0, metal:0, stone:0, wood:100}, maxProgress:0.06777777777777778, initialised:true, entsToDestroy:[]})

Net client: Disconnected

[real_tabasco_sauce]

commands.txtmetadata.json

here is a replay in which it happened. It doesn't end on a particular command.

interestinglog.htmloos_dump.txtI saw it mentioned that it occurred when a spectator joined from the lobby.

[real_tabasco_sauce]

All the errors appear (so far) to be related to rome. The only code that touched Foundation.js was the wall destruction of trees.

Maybe @Grapjas can help.

[Norse_Harold]

1 hour ago, real_tabasco_sauce said:

here is a replay in which it happened.

In the replay, a player as Romans sends all non-cavalry units to build a farmstead, kill a chicken, then walk away. Then the replay ends. Can you confirm that this is the right replay?

I was unable to reproduce the symptoms of the game crashing by following the same steps with a single player match using community-mod v0.26.11. Is something else necessary? For example, did you have a spectator join the game in order to get the game to crash?

Please list the exact steps to reproduce the symptoms.

Edited September 9 by Norse_Harold

[Norse_Harold]

1 hour ago, Philip the Swaggerless said:

Should I also send crashlog.dmp?

No, but send replays, please. The simpler and shorter, the better.

Edited September 9 by Norse_Harold

[real_tabasco_sauce]

1 hour ago, Norse_Harold said:

Please list the exact steps to reproduce the symptoms.

Its very hard to reproduce. It has happened both with and without spectators.

The only common denominator I know of is the romans.

Edited September 10 by real_tabasco_sauce

[Philip the Swaggerless]

1 hour ago, Norse_Harold said:

No, but send replays, please. The simpler and shorter, the better.

Here is the reply commands portion.  no metadata was saved though...

By the way, I just played some single player games and had no issue.

commands.txt

[real_tabasco_sauce]

possible lead:

https://gitea.wildfiregames.com/0ad/0ad-community-mod-a26/pulls/4/files#diff-f8ba294e053371dce7a50759dae18522c3e0c09a:~:text=out the way-,// out the way,},-// The obstruction always

 

[Norse_Harold]

If IsFinished() is called more than once on a foundation that is at buildprogress of 1.0 then obstructing entities can be destroyed more than once. Unexpected results may occur.

I added some logging statements and confirmed that entities are getting destroyed more than once.

I think that the solution is to clear entsToDestroy after the entities in it are destroyed.

I've attached a patch that demonstrates this.

0ad-community-mod-02611-maybefixed.patch

[Norse_Harold]

Another possibly unwanted behavior that I notice is that obstructing entities that would normally be destroyed at the moment that the foundation is created will instead be delayed and only destroyed after the building is finished. I wonder if this could disrupt pathfinding when units are standing on the foundation at the time that construction is intended to begin.

A solution to this problem would be to only delay destruction of obstructing entities if the structure to be built is a wall and the obstructing entities are trees.

[real_tabasco_sauce]

18 minutes ago, Norse_Harold said:

If IsFinished() is called more than once on a foundation that is at buildprogress of 1.0 then obstructing entities can be destroyed more than once. Unexpected results may occur.

I added some logging statements and confirmed that entities are getting destroyed more than once.

I think that the solution is to clear entsToDestroy after the entities in it are destroyed.

I've attached a patch that demonstrates this.

0ad-community-mod-02611-maybefixed.patch 698 B · 0 downloads

it would be interesting if this fixes the problem. Many of the problems have occurred when building over no entities, ie just building a farmstead when expected.

[Norse_Harold]

48 minutes ago, real_tabasco_sauce said:

it would be interesting if this fixes the problem. Many of the problems have occurred when building over no entities, ie just building a farmstead when expected.

In my testing, I was seemingly building over no entities, but I think that there are less visible or invisible entities that are being automatically deleted when buildings are constructed there.

Also, I see your proposed changes in the fix_crash branch to re-add `return false` in Commit in Foundation.js. This is good. I think that it will correctly prevent building placement if there is an obstructing entity that is not caught by BuildRestrictions.js:CheckPlacement, such as an entity that moves into the area between the time that CheckPlacement() is called and Commit() is called. An example would be another structure being placed there in that time. This is a guess, though. I don't know whether there is actually a race condition there. Edit: Actually, I think that the purpose of the call to GetEntitiesBlockingConstruction() is to check whether there are units blocking construction and order them to move out of the way.

I think that a correct solution would involve all three changes

• apply my patch to clear entsToDestroy after the entities in it are destroyed
• re-add return false on line 275 of Foundation.js, in Commit(), if there are obstructing entities. However, if the building to construct is a wall and the obstructing entities are only trees then do not return false in that case
• in Commit at line 259, immediately destroy all obstructing entities that would be destroyed on construction except trees. If the entity to be built is a wall then queue trees for later destruction

Some of the code would seem to be redundant. Is there a way to move the wall/tree code block into a separate function so that it can be used by CheckPlacement() and Commit()?

Edited September 10 by Norse_Harold

[real_tabasco_sauce]

2 minutes ago, Norse_Harold said:

In my testing, I was seemingly building over no entities, but I think that there are less visible or invisible entities that are being automatically deleted when buildings are constructed there.

Also, I see your proposed changes in the fix_crash branch to re-add `return false` in Commit in Foundation.js. This is good.

I think that a correct solution would involve all three changes

• apply my patch to clear entsToDestroy after the entities in it are destroyed
• re-add return false in Commit if there are obstructing entities
• immediately destroy all obstructing entities that would be destroyed on construction except trees. If the entity to be built is a wall then queue trees for later destruction

Well restoring return false was problematic as it would result in endless construction when building a wall segment on top of a tree.

That being said, I was unable to cause the crashing after this change in 2 multiplayer games.

[real_tabasco_sauce]

@Norse_Harold what were your steps to try and reproduce the crash? Did you get any crashes with the patch you shared? lmk if you want to test something.

Edited September 10 by real_tabasco_sauce

[real_tabasco_sauce]

Also, did anyone observe a crash in a game where nobody played as romans?

Edited September 10 by real_tabasco_sauce

[Norse_Harold]

1 minute ago, real_tabasco_sauce said:

@Norse_Harold what were your steps to try and reproduce the crash?

I mimiced the Romans player in PhiliptheSwaggerless's replay. I was not able to reproduce the crash. But I only intended to cause multiple destroy calls per entity, and I was successful in that.

To see that, use the attached Foundation.js file which enables logging. Then build lots of structures and watch the logs for multiple occurrences of "destroying entity #", where # is the same number for each occurrence. It may help to build structures with lots of units and on top of grass actors.

Foundation.js

[real_tabasco_sauce]

3 minutes ago, Norse_Harold said:

I mimiced the Romans player in PhiliptheSwaggerless's replay. I was not able to reproduce the crash. But I only intended to cause multiple destroy calls per entity, and I was successful in that.

To see that, use the attached Foundation.js file which enables logging. Then build lots of structures and watch the logs for multiple occurrences of "destroying entity #", where # is the same number for each occurrence. It may help to build structures with lots of units and on top of grass actors.

Foundation.js 14.55 kB · 0 downloads

Were you in multiplayer? The crashes only seem to happen in multiplayer with a player opponent or spectator.