maroder Posted September 16, 2021 Report Share Posted September 16, 2021 (edited) 3 minutes ago, real_tabasco_sauce said: Would it be bad to simply give each gaia tree(provided its part of a generated forest) this aura Generally speaking no, but auras can be computational intensive, so attaching it to every tree seem like guaranteed lag. Edited September 16, 2021 by maroder 1 Quote Link to comment Share on other sites More sharing options...
real_tabasco_sauce Posted September 16, 2021 Report Share Posted September 16, 2021 @maroder yeah, thats what I feared. Could the forest floor instead be used to give the aura as long as it could be taken away in the absence of trees on the forest floor? Maybe that would be no more efficient than giving the aura to each tree. Quote Link to comment Share on other sites More sharing options...
maroder Posted September 16, 2021 Report Share Posted September 16, 2021 The forest floor itself no, because it is not an "entity" for the simulation its just graphics. But one could create an invisible entity/ actor and place it inside the forest to do that. So yes I guess it should be possible and also more efficient. Quote Link to comment Share on other sites More sharing options...
alre Posted September 16, 2021 Author Report Share Posted September 16, 2021 yes but would you like to have vision decreased as soon as you get near a tre? Quote Link to comment Share on other sites More sharing options...
real_tabasco_sauce Posted September 16, 2021 Report Share Posted September 16, 2021 @alre I was hoping to tie it to the distribution of the forest floor and whether or not there are trees for a certain area of the floor, so single trees do not influence vision of troops in the open. I don't know exactly what is more feasible, just giving suggestions since @wowgetoffyourcellphone and others brought up stealth and ambush tactics. Should this be implemented it would also need to be decided what units are affected. Personally, I think outposts should still have a large vision radius in the forest. down the road, it would be cool to have a hero with a "guerilla warfare" perk that gives soldiers much better vision in the forest. Quote Link to comment Share on other sites More sharing options...
Ceres Posted September 17, 2021 Report Share Posted September 17, 2021 14 hours ago, maroder said: But one could create an invisible entity/ actor and place it inside the forest to do that. Would this mean that every map has to be updated to have such an invisible entity/ actor added in (certain denser) forest spots? I assume that we don't want to have decreased vision range in only light forest parts or even single trees, right? Quote Link to comment Share on other sites More sharing options...
maroder Posted September 17, 2021 Report Share Posted September 17, 2021 yes and yes 1 Quote Link to comment Share on other sites More sharing options...
Ceres Posted September 17, 2021 Report Share Posted September 17, 2021 Dommage! I hoped that no map update was needed but that it could be "auto-guessed" where such a spot should be set. Quote Link to comment Share on other sites More sharing options...
maroder Posted October 3, 2021 Report Share Posted October 3, 2021 On 09/09/2021 at 3:44 PM, alre said: I can keep making improvements if you like, my goal is to make formations good looking, and also reasonable even for competitive games, and I'd like my edits to go in the main game. coming back to the original topic here I still like the formation behavior in your mod. Why don't you make a patch so it can be discussed if/ how this can be integrated in the main game? 1 Quote Link to comment Share on other sites More sharing options...
alre Posted October 3, 2021 Author Report Share Posted October 3, 2021 I don't know how to do that. Besides, the mod itself is the patch. Unfortunately, the relevant script has been updated since, in a part that I don't know the working of. @Freagarach made the edit. Maybe he can merge the files, or help. 2 Quote Link to comment Share on other sites More sharing options...
Freagarach Posted October 4, 2021 Report Share Posted October 4, 2021 (edited) I'm happy to help, @alre! My online time is quite few lately, so it has to be asynchronous I guess, but if I can find your code somewhere (a patch on Phabricator is just as valid (and even preferential for me) since we can rebase it on-the-go) I may be able to point out what and why needs changing. (In short, please still upload on Phabricator (https://trac.wildfiregames.com/wiki/Phabricator) and I'll help you rebase it, or rebase on your behalf (if you agree).) Edited October 4, 2021 by Freagarach 1 1 Quote Link to comment Share on other sites More sharing options...
alre Posted October 5, 2021 Author Report Share Posted October 5, 2021 @Freagarach this is the patch. It's my first patch and I didn't really know how to do it, so there are potentially many things wrong, in fact I also created this other patch by mistake, with the other file in my original post proposing the mod. About that, if you are going to make some test, consider that I've being trying to sort unit_list before line 755 (here in the correct diff), but no kind of sorting seems to have any effect, and I have no idea why. For merging the files, and all the phab-related processes, I can take any instruction and try to do them myself, however, I should really know what's the purpose of the parts of the file that you edited in the meanwhile, because noone told me yet. 1 2 Quote Link to comment Share on other sites More sharing options...
Freagarach Posted October 5, 2021 Report Share Posted October 5, 2021 Thanks for the patch! As for things wrong, you did the best thing right: contributing! 1 hour ago, alre said: should really know what's the purpose of the parts of the file that you edited in the meanwhile, because noone told me yet. I've done two things: In https://code.wildfiregames.com/rP25947 I differentiate between entities that have finished their original task (called "finishedEntities" now, it was called "waitingOnController") and entities that are IDLE (stored in "idleEntities"). The rest is UnitAI and doesn't really matter. It seems your patch doesn't need any update for this. In https://code.wildfiregames.com/rP25949 I reduced some duplication when selecting another formation and it doesn't influence your diff. 2 Quote Link to comment Share on other sites More sharing options...
Freagarach Posted January 26, 2022 Report Share Posted January 26, 2022 @alre How do you want to be credited in the game's credits for your patch? 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.