Vantha Posted September 4 Report Share Posted September 4 My tendency would be to treat defeated players as observers and cut them off from their former allies - they can no longer access the team chat at that point either. However, they could still keep their color when flaring to observers - they also keep their color in the global chat. 1 Quote Link to comment Share on other sites More sharing options...
real_tabasco_sauce Posted September 4 Report Share Posted September 4 If possible, it would be a nice touch to hide the observer flares of players you have muted. Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 5 Report Share Posted September 5 You cannot mute players in vanilla no ? Quote Link to comment Share on other sites More sharing options...
Vantha Posted September 5 Report Share Posted September 5 To my knowledge, players can only be muted in the lobby chat, but not the pregame or ingame chats. I wonder why, though, since hosts can already kick and ban players - so, I imagine adding a mute command to be pretty straightforward. 15 hours ago, real_tabasco_sauce said: If possible, it would be a nice touch to hide the observer flares of players you have muted. I'd even go as as far and say this is a must, flares can be much more annoying than chat messages. Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 5 Report Share Posted September 5 15 minutes ago, Vantha said: To my knowledge, players can only be muted in the lobby chat, but not the pregame or ingame chats. I wonder why, though, since hosts can already kick and ban players - so, I imagine adding a mute command to be pretty straightforward. I'd even go as as far and say this is a must, flares can be much more annoying than chat messages. See https://code.wildfiregames.com/D4871 And @Itms rewrite here https://gitlab.com/na-Itms/0ad/-/compare/master...moderation?from_project_id=188465  1 Quote Link to comment Share on other sites More sharing options...
real_tabasco_sauce Posted September 5 Report Share Posted September 5 (edited) They can be muted in game and in observer chat. And it carries over from the lobby and vice versa. Edited September 5 by real_tabasco_sauce Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 5 Report Share Posted September 5 17 minutes ago, real_tabasco_sauce said: They can be muted in game and in observer chat. And it carries over from the lobby and vice versa. Isn't that autociv ? Quote Link to comment Share on other sites More sharing options...
real_tabasco_sauce Posted September 5 Report Share Posted September 5 8 minutes ago, Stan` said: Isn't that autociv ? Oh, right. It might be, there's another autociv feature that could be added to vanilla. Quote Link to comment Share on other sites More sharing options...
chrstgtr Posted September 5 Report Share Posted September 5 1 hour ago, Stan` said: Isn't that autociv ? It is. Would be nice easy feature for vanilla Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 5 Report Share Posted September 5 13 minutes ago, chrstgtr said: It is. Would be nice easy feature for vanilla See the patches linked above. IIRC most of the autociv features are hacks we can't easily port in the game. 1 Quote Link to comment Share on other sites More sharing options...
Norse_Harold Posted September 5 Report Share Posted September 5 5 hours ago, Stan` said: See https://code.wildfiregames.com/D4871 D4871 is outdated. D4987 is more in line with what I have planned. Even that is outdated, because changes are planned. Help wanted. Quote Link to comment Share on other sites More sharing options...
Vantha Posted September 11 Report Share Posted September 11 I'd like to submit the code now, but it comprises of two split features that should probably get a pull request of their own. Firstly, the chat notifications, and secondly (built on top of it) the observer flares. They are very interconnected and I would like to have both pull requests open at the same time (especially since the chat notifications would become kinda pointless should the observer flare code be rejected). How should I do that? Open a pull request on the main 0ad repo for the base code (chat notifications) and then open another one to that new branch on my fork containing the additional code (observer flares)? Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 11 Report Share Posted September 11 You can make PRs depend on one another. So you could make two PRs. One with the base changes and one with both changes in another branch Quote Link to comment Share on other sites More sharing options...
Vantha Posted September 12 Report Share Posted September 12 21 hours ago, Stan` said: You can make PRs depend on one another. How? Is there a feature I am missing? Or do you mean I should just mention it in the PR description? Quote Link to comment Share on other sites More sharing options...
Stan` Posted September 12 Report Share Posted September 12 See https://gitea.wildfiregames.com/0ad/0ad/pulls/7031#issuecomment-101118 On the left side there is something for dependencies Quote Link to comment Share on other sites More sharing options...
Vantha Posted September 12 Report Share Posted September 12 Right, but that still doesn't make it track changes between the two source branches, does it? Quote Link to comment Share on other sites More sharing options...
Vantha Posted September 12 Report Share Posted September 12 I just opened the two PRs anyway. They largely contain the same files, but are still comparably small. Changes between them shouldn't be too confusing... https://gitea.wildfiregames.com/0ad/0ad/pulls/7041 https://gitea.wildfiregames.com/0ad/0ad/pulls/7042 Quote Link to comment Share on other sites More sharing options...
Vantha Posted September 13 Report Share Posted September 13 What do you think? Should observers keep the ability (to send and see fares) while viewing the game from a specific player's perspective? Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.