Champion Iberian Cavalry

[Servo]

I noticed that a fort trained Iberian champion cavalry are not exactly the same as the one trained from the barracks. When you double click on all they are the same but if you triple click they are different. The specs are the same only when you triple click they are not.  

Im not sure if it's the same on other civs. 

Now I noticed it's the same as the champion swordsmen. 

Edited August 19, 2017 by Servo

[elexis]

The templates are indeed identical, so it's a code bug, not a template bug.

The triple-click code must check for the template name instead of the SelectionGroup name.

Reading the code (input.js), that's exactly what it does.

					// Check for double click or triple click
					if (ev.clicks == 2)
					{
						// Select similar units regardless of rank
						templateToMatch = GetEntityState(clickedEntity).identity.selectionGroupName;
						if (templateToMatch)
							matchRank = false;
						else
							// No selection group name defined, so fall back to exact match
							templateToMatch = GetEntityState(clickedEntity).template;

					}
					else
						// Triple click
						// Select units matching exact template name (same rank)
						templateToMatch = GetEntityState(clickedEntity).template;

Since that comment exists since r11178, I'm lucky it's not another bug of the alpha 22 doubleclick patch

The rank parsing was odd in different places already.  @Imarok did some work with that already, but he's busy atm.

Can you report this bug at http://trac.wildfiregames.com/?

[fatherbushido]

Perhaps I didn't understand but those units don't have the same template name (they aren't the same unit).

edit: to explain a bit more, it will be the same for all champs unlocked in barracks

[LordGood]

barracks trained champions have longer train times, ergo needs a different template, same with women trained from houses and the CC

[fatherbushido]

@LordGood: it's not related to the train time

[elexis]

36 minutes ago, fatherbushido said:

Perhaps I didn't understand but those units don't have the same template name (they aren't the same unit).

edit: to explain a bit more, it will be the same for all champs unlocked in barracks

Well, the code works as the comments intend it to work:

Double-clicking: // Select similar units regardless of rank

Triple-clicking: // Select units matching exact template name (same rank)

It's just not expected by the user I guess.

[fatherbushido]

27 minutes ago, elexis said:

Well, the code works as the comments intend it to work:

Double-clicking: // Select similar units regardless of rank

Triple-clicking: // Select units matching exact template name (same rank)

It's just not expected by the user I guess.

Yes

edit: so not really a code problem :/ and no idea for a not hacky solution :/

edit2: perhaps our current construction is hacky btw

[Servo]

@elexis Idk how to report this. This will only affect much when you use Alt-triple click though very important when it comes to this type of champions as they are game changer. 

[Zeta1127]

Champions and Women are both treated as different units when trained from the Barracks and House verse the Fortress and Civic Center, respectively. This is part of the reason why I never boom with Houses.