Diplomacy broken since Rev. 27722

[Mr.lie]

Since SVN-Revision 27722 (Pull Diplomacy out of cmpPlayer) you can't load a saved game.

interestinglog.html mainlog.html savegame-0001.0adsave metadata.json commands.txt

[phosit]

Hello Mr.lie, Thank you for the report.

Can you try to make and load a new savegame with the proposed fix at https://code.wildfiregames.com/rP27722 ?

[Mr.lie]

Hi phosit,

with this fix P27722 it's the same - same errors as in the first post.

When i detect this error (or others) after an SVN-Update, i have a strategy to find out which fix causes the error: i use the contextmenu of "TortoiseSVN - Update to revision...", update (in my cases it's downgrade) to the next smaller revision, clear the game cache, start a new game and look for errors. This way after dozens "Update to revision...." the error disappears after "downgrade" to revision 27721!

 

[gameboy]

@wraitii

[Freagarach]

Thanks for the report, @Mr.lie! I've fixed this issue in https://code.wildfiregames.com/rP27824.

[Mr.lie]

Thank you for the quick fix. There is still another error: the "Dipomacy" button throws an error, even on a new game or a saved game. I've attached the log file.

Pyrogenesis Log.htm

[gameboy]

@Freagarach

[Mr.lie]

On 04/09/2023 at 5:47 PM, Mr.lie said:

Thank you for the quick fix. There is still another error: the "Dipomacy" button top right throws an error, even on a new game or a saved game. I've attached the log file.

Pyrogenesis Log.htm 1.52 kB · 28 downloads

Hi, this issue isn't fix yet, so you cannot use "Diplomacy" anyway

Edited April 13, 2024 by Mr.lie

[gameboy]

@Freagarach

[Stan`]

@gameboy can you create a ticket with a replay attached to reproduce this issue?