Better Boats Mod

[Asher]

Spoiler

I started making a mod that is supposed to make boats better. So far, I've increased health for all arrow and siege ships, increased resistance for arrow, siege, and ram ships. And some more stuff. https://github.com/Jeff-web-sketch/BetterBoats. I am thinking turret-able units would be cool on boats, but is that possible? If you have any input on how boats could be made better, I would be glad to have your input.

So, this is now going to be a PR that adds a turret position to boats

Edited 5 hours ago by Asher

[Asher]

So, I got the turreting working, but they are surviving when the boat is destroyed, and they can walk underwater. Is there a way for them to, um, not survive the boat sinking?

[Stan`]

2 hours ago, Asher said:

So, I got the turreting working, but they are surviving when the boat is destroyed, and they can walk underwater. Is there a way for them to, um, not survive the boat sinking?

IIRC garrisoning has such logic

[Asher]

1 hour ago, Stan` said:

IIRC garrisoning has such logic

But is there a way to do that with turreting?

[Asher]

So, I am trying to make an aura that increases range. How would I do that?         { "value": "Attack/Ranged/Range", "multiply": 2 },

[Stan`]

1 hour ago, Asher said:

But is there a way to do that with turreting?

My point was that if garrisoning does it, then yes it's possible to copy the code and do it.

1 hour ago, Asher said:

So, I am trying to make an aura that increases range. How would I do that?         { "value": "Attack/Ranged/Range", "multiply": 2 },

https://gitea.wildfiregames.com/0ad/0ad/wiki/TechModifications

[Atrik]

12 hours ago, Asher said:

But is there a way to do that with turreting?

Sounds like something that should be handled in vanilla and not require mods to implement the logic. You should open a issue for it, I might pick it up myself. If you do, attach a dummy template of boat with turret point to make the testing easier.
Or if you can't wait next release and you just want to do it yourself, please open a PR on main repo that would be most useful.

[Asher]

6 hours ago, Atrik said:

Sounds like something that should be handled in vanilla and not require mods to implement the logic. You should open a issue for it, I might pick it up myself. If you do, attach a dummy template of boat with turret point to make the testing easier.
Or if you can't wait next release and you just want to do it yourself, please open a PR on main repo that would be most useful.

I was planning to do a PR, but  I couldn't get the game to build on my device. Do you want to help me, @Atrik?

Edited 15 hours ago by Asher

[Atrik]

2 hours ago, Asher said:

I was planning to do a PR, but  I couldn't get the game to build on my device. Do you want to help me, @Atrik?

Post your issue here or another thread, if I know how to help, I will. If not, someone else will probably  

[Asher]

4 hours ago, Atrik said:

Post your issue here or another thread, if I know how to help, I will. If not, someone else will probably  

Would you want to help with adding the script to turretholder.js that ejects units on destory? 

[Asher]

So, how do I make a PR, do I need to be added to a list of editors for the repo?

[guerringuerrin]

50 minutes ago, Asher said:

So, how do I make a PR, do I need to be added to a list of editors for the repo?

Perhaps this basic guide will be helpful

 

[guerringuerrin]

Also read the commit guidelines and you can always check the Wiki.

And this is a very user-friendly guide to the basics of Git. 
The hard data is here: https://git-scm.com/learn

 

[Asher]

Ok thanks @guerringuerrin! Would anybody want to help me with adding the eject units on boat death? Also, the PR is #9211

[guerringuerrin]

2 hours ago, Asher said:

Ok thanks @guerringuerrin! Would anybody want to help me with adding the eject units on boat death? Also, the PR is #9211

I don't have time these days to investigate it, but the first thing I would do is follow @Stan` advice and study how it's implemented in the garrison