Jump to content

Leaderboard

Popular Content

Showing content with the highest reputation on 2024-07-11 in all areas

  1. About the names it would be nice to have the greek name next to the latinised version, just like specific and generic names for units For the numbers I'm not familiar with what we do in the game
    1 point
  2. Sounds like it's compatible with our English style guide. I guess I can make a "community writer" badge. https://code.wildfiregames.com/differential/ On that page click create diff: Paste the raw diff generated by git diff -x -U5000 Set the repository to rDD 0 A.D. Design Document, then fill the form Now for reviews that's a bit trickier, since there is no one in charge. But unless it's huge changes, it should be okayish. You can see the generated version here https://docs.wildfiregames.com/design/ More stuff here https://docs.wildfiregames.com/
    1 point
  3. https://gitea.itms.ovh/explore/repos (When you click the explore menu at the top)
    1 point
  4. Yes, but in a private repo. Not directly related to the migration, but is code or documentation for the set up of the new infrastructure available somewhere? I find being able to do pull requests for infrastructure as well pretty helpful. I'm in favor of sunsetting Trac and Phab as fast as possible and as long as the links continue to work, by being redirected to Gitea. True. I also disliked the fact you could make the diff private on Phab because that's kind of anti open source to me and moreover it broke the bot as well. If you're gonna have private code maybe don't share it at all... There are valid cases for having stuff with limited visibility at first. I'm thinking about proposed changes and associated discussions which relate to serious security vulnerabilities, where vulnerability details shouldn't be public before a fix is shipped. However, I guess even with everything open on Gitea, we can handle such situation through other channels. Also mind that limiting repositories for users doesn't help much against spam/malicious stuff, if forking existing repositories is still possible, as one can simply replace the content of the forked repository with something else. I'd like to keep trunk for historical/nostalgic reasons, and also because I'd like us to explicitly follow a trunk-based development model. I am open to discussion about that. The vast majority of git repository uses "master" or "main" as their primary branch name. I'd prefer doing so for 0ad as well, as people are used to it. I actually can't remember having ever seen a git repository using a branch named "trunk" as their primary branch. Just recently I was working on a git repository which used a different name for their primary branch and it was such a PITA, as muscle memory (git checkout ma<TAB>) didn't work. What do you mean about surprising? In terms of privacy you mean? (if yes, I tried to be precise in the privacy policy, and people who don't use Gravatar won't have their data sent there, so they are not supposed to complain unless I missed something). For the PoC, getting the profiles from Gravatar allows one to have a sense of the look and feel of the platform and of the community interactions. I wouldn't like to see everyone with generated avatars... For the actual migration, active users will be able to populate their profile, but IMO it would be a bit of a shame to leave all the old members of the community without a face. I'm very happy to see a profile pic associated with janwas or k776 for instance. As Gitea is configured right now, for every request where a profile image is meant to be shown, a request for the user whose image is supposed to be shown is made to Gravatar, unless that user uploaded an own image in Gitea. As these requests happen for every visitor, Gravatar is able to track visitors of our Gitea instance, without them being able to consent to this first. I believe this doesn't comply with GDPR. Upstream Gitea now also ships with OFFLINE_MODE=true by default (https://github.com/go-gitea/gitea/pull/28548), which disables requests to gravatar.com and other external services. Did Phabricator even support Gravatars or were all profile images there uploaded by the users themselves? Maybe it'd be an alternative to migrate the existing profile images from Phabricator to Gitea instead.
    1 point
  5. I'm not the sole decider for this, but what do you expect for the "official" part? As opposed to say, community balancers. There is indeed a lot of writing to be done on 0 A.D. whether it's in the game or in the documentation, but you currently do not need more permissions that you currently have There is also the design document, that has never been updated to reflect the current state of the game that could benefit from a polish. Then there are the side tasks like adding new tips to the game https://code.wildfiregames.com/D4189 @Nescio did a very good job standardizing unit tooltips and whatnot and perfecting the english style guide. There were also some more debatable changes like changing stone to rock and and metal to ore in the editor but overall it brought a layer of consistency which is welcome. Now I must warn you though, this is a thankless job, and it will often happen that stuff gets in and needs to be corrected afterwards.
    1 point
×
×
  • Create New...