old brit and gaul fortress models in dev version (24)

[Hidan]

hi i do remember there are another one gaul and brit fortress in 23. is this a bug?

[Silier]

@Stan` ? 

[Stan`]

Broken by https://code.wildfiregames.com/rP24919#change-8EjCxaI5SRRT

It seems setting variants ignores the frequency="0" not sure why.

[wraitii]

3 minutes ago, Stan` said:

It seems setting variants ignores the frequency="0" not sure why.

What do you mean?

[Stan`]

14 minutes ago, wraitii said:

What do you mean?

Well those variants have frequency="0" but sill get picked because they are before (in the file) the frequency="1" variant

[Stan`]

More scaringly.

<variant frequency="0" name="Briton Fortress Old" file="structures/defensive_building.xml">
<variant  file="structures/defensive_building.xml" frequency="0">
<variant name="Briton Fortress Old" file="structures/defensive_building.xml">
<variant name="Briton Fortress Old" file="structures/defensive_building.xml" frequency="0">

are equivalent

 

<variant file="structures/defensive_building.xml" name="Briton Fortress Old">
<variant file="structures/defensive_building.xml" name="Briton Fortress Old"  frequency="0">

 

work.

current

    <variant frequency="0" name="Briton Fortress Old" file="structures/defensive_building.xml">

 

 

EDIT: IMHO variant should always be last to be overriden.

Refs: https://code.wildfiregames.com/rP18054

https://trac.wildfiregames.com/ticket/3286

 

EDIT2: https://code.wildfiregames.com/D3572

 

[wraitii]

Ah so you mean in the file they are frequency=1, and overwriting it with frequency=0 doesn't work ?

[Stan`]

Yep see EDIT2