Error in timer on entity !

[gameboy]

Today, I tested SVN22432 and found an error:

The map I tested was the Thessaly Plain (4).

@wraitii

ERROR: Error in timer on entity 8519, IID96, function TimerHandler: TypeError: herdPos is undefined UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.GATHER.GATHERING.Timer@simulation/components/UnitAI.js:2293:1 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12 UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3769:2 Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4

ERROR: Error in timer on entity 8514, IID96, function TimerHandler: TypeError: herdPos is undefined UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.GATHER.GATHERING.Timer@simulation/components/UnitAI.js:2293:1 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12 UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3769:2 Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4

ERROR: Error in timer on entity 8536, IID96, function TimerHandler: TypeError: herdPos is undefined UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.GATHER.GATHERING.Timer@simulation/components/UnitAI.js:2293:1 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12 UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3769:2 Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4

ERROR: Error in timer on entity 8512, IID96, function TimerHandler: TypeError: herdPos is undefined UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.GATHER.GATHERING.Timer@simulation/components/UnitAI.js:2293:1 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12 UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3769:2 Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4

ERROR: Error in timer on entity 8518, IID96, function TimerHandler: TypeError: herdPos is undefined UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.GATHER.GATHERING.Timer@simulation/components/UnitAI.js:2293:1 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12 UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3769:2 Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4

 

commands.txt

Edited July 4, 2019 by gameboy

[wowgetoffyourcellphone]

Did you rebuild the exe? 

[gameboy]

Yes, When you test it, you will find this problem again.

[wraitii]

There's a mistake... I incorrectly assumed that we would always have a herd position set if I set it in Order.Gather, but that might not be true.

Reproduction needs multiple units that gather from one resource, and doesn't always happen.

I'll fix that tonight.

[wraitii]

This has been fixed, thanks for your patience.

The remaining issues are going to be fixed also over the next few days and weeks, see https://github.com/wraitii/0ad/tree/D13_outtakes for an up-to-date view of upstream changes.