Special Formation Animations stop working when idle

[wowgetoffyourcellphone]

In Syntagma or Testudo, the special animations for idle stop working when formation stop moving. Anyone else verify?

[Phalanx]

I can.

[elexis]

Is it the old bug with errorspam or is it solely the animation? The animations had been rewritten in alpha 21 and there were some things like that already.

[Stan`]

I think its solely the animation, which makes it quite stupid since unit will break testudo as soon as they stop.

[elexis]

Replay?

Can anyone test whether alpha 20 has it too?

[fcxSanya]

On 03.11.2016 at 5:25 PM, elexis said:

Can anyone test whether alpha 20 has it too?

Yes, it does.

On 03.11.2016 at 5:25 PM, elexis said:

Replay?

testudo_animation_test_a20.zip -- a20, I started the roman sandbox map, gathered some starting units into testudo and moved back and forth a bit.

[fcxSanya]

Also reproducible in a19, but works properly in a18.

[wowgetoffyourcellphone]

1 hour ago, fcxSanya said:

Also reproducible in a19, but works properly in a18.

Let us go deeper: does ir work properly in a1?

[fcxSanya]

12 minutes ago, wowgetoffyourcellphone said:

Let us go deeper: does ir work properly in a1?

You are going in a wrong direction, as soon as you have a working version and a broken one, you have to bisect between them.

a18 is r16411, a19 is r17298 and the issue seems to be caused by r17036

[wowgetoffyourcellphone]

Is joke. There were not formation in a1.

[elexis]

a19 had the new pathfinder, but there were also some formation changes http://trac.wildfiregames.com/search?changeset=on&q=formation&page=2&noquickjump=1, 3086 perhaps

[fcxSanya]

13 hours ago, elexis said:

a19 had the new pathfinder, but there were also some formation changes http://trac.wildfiregames.com/search?changeset=on&q=formation&page=2&noquickjump=1, 3086 perhaps

I linked the revision which broke it above (r17036), reverting it fixes the animation, but then the issue from #3429 should return (unless it was fixed by something else in a different way). Maybe the code from r17036 can be enhanced to select the formation-specific animation rather than always returning to 'idle' on "MoveCompleted"?

[elexis]

That's enough material for a ticket with the pathfinding keyword. Perhaps we should also add the "formation" keyword to related tickets.

[fcxSanya]

On 07.11.2016 at 2:37 PM, elexis said:

That's enough material for a ticket with the pathfinding keyword. Perhaps we should also add the "formation" keyword to related tickets.

I created a ticket: #4318, not sure about the 'pathfinding' keyword though, it's UnitAI logic which is related to movement states, but not to pathfinding logic itself. I added 'UnitAI' and 'formations' keywords for a start, feel free to edit as necessary.