Entity ID shouldn't be changed.

[Atrik]

I remembered that this edge bug was reported by @Darkcity and labeled as release blocker.
Another bug that occur with this map is that if you play Hans and upgrade CC, you'll be considered defeated because your CC id has changed.

Ideally entity id shouldn't be changed on upgrade, pack/unpack, or anything. This results in this kind of complications. I also would love to track some statistic per entities but this is making it difficult.

2nd bug:  Currently upgrading pers immortals while they attack can sometimes trigger an error in Unit_AI. IIRC it's not related to the id change but rather make range manager fail. @real_tabasco_sauce

[Stan`]

39 minutes ago, Atrik said:

Ideally entity id shouldn't be changed on upgrade, pack/unpack, or anything. This results in this kind of complications. I also would love to track some statistic per entities but this is making it difficult.

https://code.wildfiregames.com/D4991

@Atrik could you provide a minimal replay of the bug(s) so we can open issues?

[Atrik]

commands.txt Hans CC upgrade on Survival of the Fittest.

For the immortal upgrade I'm not able to reproduce, but it can happen multiple time a game. Doesn't seems to break anything. Just throw a error. I'll past it here if I come across it again.

[real_tabasco_sauce]

imo there should be an overhaul to add a system dedicated to turning one unit into another. It could address this, as well as the promotion 'hack', and stuff like https://gitea.wildfiregames.com/0ad/0ad/issues/7328