Vantha

I suggest we add the page to the game now (after fixing the bug), but only with selected articles for testing. The review process will take a lot of time anyway and in parallel we can already "customize" the rest of the articles (adding images, subtitles, links to other articles, etc.). And as soon as the page framework is merged we can add the bulk of articles to the game too. I don't think incompletion is be something to worry about in this case, since the page framework is indeed complete and we can simply remove the button from the main menu as long as it doesn't contain all the articles to prevent players from finding a (seemingly) incomplete and empty page in a full release. And the existence of temporarily unused files in 0ad's code wouldn't be anything new either. Howevere, I will talk to some developers and adapt to what they deem best. I made the mod for the latest version, but it should be working with A26 (except the unit portraits) as well. Have you verified the mod is installed properly? Does anyone else face the same issue? You can try opening the javascript console with the assigned hotkey (per default '^' and F9) and entering the following command: Engine.SwitchGuiPage("page_encyclopedia.xml");

Big news regarding the encyclopedia page! New features: - the ability to put images in the article header. I decided to place the images to the top right and the title to the top left. This saves a lot of space compared to other possibilities and it looks good with images of most aspect ratios. But I will talk more in depth about the implementation in a future post. - the ability to add subtitles. They are fully optional, but really enhance the header's visual appeal (in my opinion). - a button below the title that opens up the the template viewer showing the unit's in-game stats. Its portrait is embedded into the button, so players can visually recognise the unit from in-game as well. - buttons to directly switch to the next or previous article in the same subcategory (to the suggestion of @nifa) They currently do not include any text as I think the arrow sprites are enough of a hint as to what the buttons do. Here is a quick showcase: screen-recording-0ads-encyclopedia.mp4 Other improvements: - fixed GUI scaling on lower screen resolutions (down to 1024x768). This turned out as quite a hassle, but it had to be done eventually. I haven't tested it on large screens (yet), mainly because they usually don't cause problems. If you notice any problem with the GUI scaling, let me know. As always I packed it into a mod, please try it out, any feedback is welcome! encyclopedia.zip (unfortunately I have not yet managed to resolve the issue with the crashes, I recommend trying to open it multiple times and supressing the error, if you notice any patterns or have any idea on how to resolve it, please let me know)

.

I agree. I think any decent team game rating system would bring a good improvement over the current system, just because most players play more team games than 1v1s and a higher number of rated games will automatically result in a more accurate rating. We wouldn't even need to abandon the current rating system, players can have both 1v1 and team game ratings at once. I can't even imagine it to be that hard to implement, the problem is a lack of manpower. However, if anyone decides to start working on it, I am open to help coding it.

I just uploaded a patch: https://code.wildfiregames.com/D5297

Han minister To my understanding the name currently in use ("官吏 Guānlì") is a collective term for government officials ( which is obviously not wrong, as ministers symbolically represent the entire government). However, after all, the unit is still called "minister" and limited to nine at a time in reference to the Han dynasty's nine ministers. And these nine ministers (/ chamberlains) were called "九卿 jiǔ qīng" with "九 jiǔ" translating to "nine" and "卿 qīng" translating to minister(s) or other high ranking officials. Here is the change I am suggesting: Guānlì -> Qīng Sources:

Wow, that's so much more simple than I hoped for. It even allows to get the actually displayed size for GUI objects directly as well. Thanks.

Is it possible to read the screen resolution from JavaScript scripts? If so, how?

Good idea. Or maybe 'Tiger Guard Spearman'. Much better (and more unique) than just 'imperial/palace guard spearman'.

Han champion spearman (Hǔ Bēn) This time it's about the GenericName (the translated descriptive name): At the moment, this unit is called "Palace Guard Spearman". "虎賁 Hǔ Bēn" (usually translated to something like "Rapid as Tigers") were indeed a guard unit stationed around palaces. However, they were not actually responsible for guarding the palaces, but rather the emperor himself (who just happened to spend most of his time at palaces). This distinction is important because there was another (completely separate) unit specifically assigned to just guard all palace buildings – even in absence of the imperial family. The Han bureaucracy strictly differentiated between corps of imperial guards and palace guards - so much so, in fact, that they had two different ministries for them. Thus here is the change I'm suggesting: Palace Guard Spearman -> Imperial guard spearman (It would be cool to also include "Rapid as Tigers", but I'm afraid it would feel out-of-style with the names of other units) Sources:

I opened a second editing pr for some Athenian units that were left untouched in the first one https://github.com/TheShadowOfHassen/0-ad-history-encyclopedia-mod/pull/152

@guerringuerrin Ok. As explained here, the icon tag has a property called 'displace' that allows moving the icon on the x and y axis by a certain number of pixels. Now, the target icons measure 32x32 pixels while the font is only 16 pixels high. A downwards offset by half the difference (in this case 8 pixels) perfectly centers the icon on the text => displace="0 8". (The text might appear a bit smaller than 16 pixels because it mostly contains lowercase letters, so I suspect an offset of 9 pixels might look slightly better, but you'll have to be the judge for that) I suggested according changes to the latest merge request.

Sure, I can help with that. Where is the code? I don't see a merge request for it.

Not exactly sure if I understand that correctly, what appendage string do you mean? Maybe the best way would be to simply store the images' resolutions somewhere in a file and read it from there.

I have an image GUI object and would like to dynamically resize it to its texture's aspect ratio. Is it possible to read an image file's resolution in JavaScript or does it require editing the C++ source code?

Does deleting the 'simulation' folder help? It only contains (currently unused) links to some articles inside the XML templates.

Thanks. Well, the log files didn't contain any error messages last time... Is the crash message the same as before?

Ok, I can picture what you mean now, that might indeed be useful to have. I'll see what I can do. You've downloaded the mod from the GitHub repo, correct? Deleting the .gitattributes, the README.md, and the Setup.js should get it working. By the way, if anyone is interested, Setup.js is the script which I'm using to make the directories, extract the data from the xmls, categorize them, and create the json files. I'm running it with NodeJS and its filesystem and xmlBuilder package.

Interesting idea. We currently only have the section for related articles on the right (which is currently empty because they have to be filled manually). Adding a button below the articles that simply opens the first of them (i.e. "the next page") won't be hard to implement. I'm sure some players would prefer the feeling of leafing through a book rather than of clicking through menus. No, of course not. I'm still unsure what to go for with the images.

Hmm, not sure if I like the large square portraits. They take up so much space.

Where would you place them on the page? Images would be great, but the articles themselves should remain the focus point of the layout.

Can someone share their log files after the error occurs?

After suppressing, is there any texture that isn't correctly loaded in?

I'm pretty sure not. As far as I know that throws a different error.

I used the A27 release candidate, but have also (successfully) tested it on the latest development version.