Game crashes when it cannot find a terrain

[wowgetoffyourcellphone]

So, the game and Atlas crashes when it cannot find a terrain texture. It used to just render that terrain as magenta without any further problems, but the current build simply hard crashes when the missing terrain comes into camera view. 

This is everything that appears in the log:

WARNING: CTerrainTextureManager: Couldn't find terrain alpine_grass_c_fancy

 

I don't know how long this has been the case. I just remember it used to not hard crash like this, just paint a magenta color instead.

crashlog.dmp crashlog.txt interestinglog.html mainlog.html system_info.txt userreport_hwdetect.txt

[vladislavbelov]

45 minutes ago, wowgetoffyourcellphone said:

I don't know how long this has been the case.

That should be pretty old bug.

45 minutes ago, wowgetoffyourcellphone said:

I just remember it used to not hard crash like this, just paint a magenta color instead.

Magenta happens when you have XML for the terrain type, but not the DDS/PNG texture. It crashes when PMP refers to a not existing XML file for terrain IIRC.

[vladislavbelov]

Stack:

Spoiler

CPatchRData::AddBlend(std::vector<CPatchRData::SBlendVertex,std::allocator<CPatchRData::SBlendVertex> > & blendVertices, std::vector<unsigned short,std::allocator<unsigned short> > & blendIndices, unsigned short i, unsigned short j, unsigned char shape, CTerrainTextureEntry * texture) Line 323
CPatchRData::BuildBlends() Line 267
CPatchRData::CPatchRData(CPatch * patch, CSimulation2 * simulation) Line 71
TerrainRenderer::Submit(int cullGroup, CPatch * patch) Line 113
CSceneRenderer::Submit(CPatch * patch) Line 982
CGameView::EnumerateObjects(const CFrustum & frustum, SceneCollector * c) Line 256
CSceneRenderer::RenderScene(Renderer::Backend::IDeviceCommandContext * deviceCommandContext, Scene & scene) Line 1106
CGameView::Render() Line 238
CRenderer::RenderFrameImpl(const bool renderGUI, const bool renderLogger) Line 462
CRenderer::RenderFrame(bool needsPresent) Line 431
AtlasViewGame::Render() Line 233
AtlasMessage::fRenderLoop_wrapper(AtlasMessage::IMessage * msg) Line 220
MessagePasserImpl::Query(AtlasMessage::QueryMessage * msg, void(*)() __formal) Line 68

 

[andy5995]

@wowgetoffyourcellphone

Here's the fix and a little history

 

https://github.com/0ad-matters/community-maps-2/issues/47