Jump to content

SVN21848 ERROR!


gameboy
 Share

Recommended Posts

@elexis Today, I tested the latest SVN21847. When I opened the multiplayer lobby, the error message appeared: 

ERROR: RelaxNGValidator: Validation error: gui/prelobby/common/credentials/credentials.xml:2: Did not expect text in element object content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: CXeromyces: failed to validate XML file gui/prelobby/common/credentials/credentials.xml

  • Thanks 1
Link to comment
Share on other sites

Thanks gameboy!

I did not notice the bug because there is a logic problem in the XML library that is hiding this bug. :angel_not:

The library saves syntactically correct cached versions of syntactically incorrect XML files, so we see the error the first time, but then never again.

So if a dev has some errorspam and only read the first error, he may never have a chance to read this error and is mislead to believe that the XML files are syntactically and semantically correct and commit them.

Hence I propose to only save the syntactically correct cached files if the XML files were syntactically correct as well in D1574.

  • Thanks 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...