Overbrightening/Contrast in some sprites with OGL since latest renderer changes (SVN)

[wowgetoffyourcellphone]

I use OpenGL for both. No mods enabled. I can confirm this does not occur with Vulkan, but a significant portion of players will use OpenGL.

 

Alpha 26 (desirable)

Spoiler

 

Current SVN (overbrightened)

Spoiler

 

 

Alpha 26 (desirable)

Spoiler

 

Current SVN (overbrightened)

Spoiler

 

You'll see in Alpha 26 these sprites blended better into the terrain and are aesthetically pleasing, but now in SVN there's an overbrightness and contrast to their textures which makes them not blend nearly as well. The textures have not changed. Rendering them did. 

Edited August 14, 2023 by wowgetoffyourcellphone

[vladislavbelov]

Ideally it should be fixed on the art side. Because grass is kind of broken (it was hacked to look correctly for old hacky shaders).

But I made a patch to workaround it for a while (though it might be kind of blocker for PBR): https://code.wildfiregames.com/D5106

[hyperion]

@vladislavbelov,

as told on phab, those grasses also cause flickering for me under camera movement, neither renderer backend nor various graphic options matter. The attached video doesn't faithfully reproduce the issue but that is the best I managed to do playing with capture and encoding options.

[vladislavbelov]

17 minutes ago, hyperion said:

@vladislavbelov,

as told on phab, those grasses also cause flickering for me under camera movement, neither renderer backend nor various graphic options matter. The attached video doesn't faithfully reproduce the issue but that is the best I managed to do playing with capture and encoding options.

Yeah, it's a known thing. You might find it for some trees as well. First of all we need to adjust DDS converting (nvtt or compressonator) to preserve alpha correctly.

[hyperion]

Those grasses have dds sources IIRC, so no conversion happens, right?

[vladislavbelov]

5 minutes ago, hyperion said:

Those grasses have dds sources IIRC, so no conversion happens, right?

Yeah. We might reconvert (with recalculating MIPs) them or better convert them to PNG.

[hyperion]

Thanks, I think I now understand where the issue comes from.