[FIXED] Technology Bug: MinRange

[wowgetoffyourcellphone]

Tech is like this:

{	"pair": "pair_defensive_01",		"genericName": "Murder Holes",	"description": "Murder Holes allow defenders to fire or drop projectiles upon enemy units huddled along the base of the defenders' wall.",	"cost": {"food": 0, "wood": 200, "stone": 100, "metal": 0},	"requirements": {"tech": "phase_city"},	"requirementsTooltip": "Unlocked in City Phase.",	"icon": "murder_holes.png",	"researchTime": 40,	"tooltip": "Towers and Fortresses no longer have a minimum attack range.",	"modifications": [		{"value": "Attack/Ranged/MinRange", "replace": 0}	],	"affects": ["Tower", "Fortress"],	"soundComplete": "interface/alarm/alarm_upgradearmory.xml"}

But I can see when I turn on Range overlay in the game that this tech does not affect the minrange at all. Is the MinRange modification bug?

[Itms]

Did you test modifying the min range to a non-zero value, e.g. 0.1? If it works, the 0 value is the problem, else the bug is about modifying the min range.

[sanderd17]

AFAICS, the minrange is applied in the Attack component, but the BuildingAI doesn't re-define the range queries.

So new towers you build should have the modified min range, or if you change ownership or alliance of the tower. Can you confirm that?

[wowgetoffyourcellphone]

Changed it to 1, still did not change when looking at range overlay.

AFAICS, the minrange is applied in the Attack component, but the BuildingAI doesn't re-define the range queries.

So new towers you build should have the modified min range, or if you change ownership or alliance of the tower. Can you confirm that?

k, 1minute

[wowgetoffyourcellphone]

EDIT: Tested and confirm what sanderd say. The new tower show different minrange (none) than the already exist tower.

Hmm, does this happen with maxrange too? I try a range tech.

EDIT2: happen with maxrange too. Is this intend behavior? The stat in tooltip show the range has increased, but the range ring did not update.

Edited March 30, 2015 by wowgetoffyourcellphone

[sanderd17]

It's a bug, but it's pretty simple to fix. However, my SVN is a bit dirty now (even saving a diff takes ages), so if anyone else can solve it, that'd be great.

[sanderd17]

Should be fixed in http://trac.wildfiregames.com/changeset/16472

I also fixed some other things, like changing ownership to gaia might leave gaia-targetting range queries, and starting with a 0 arrow count didn't activate the BuildingAI ever (so also not if a tech modified the arrow count).

I hope it works now.