Bellaz89 Posted July 30, 2020 Author Report Share Posted July 30, 2020 (edited) @happyconcepts Yes, there was. It is fixed in https://code.wildfiregames.com/D2869 Edited July 30, 2020 by Bellaz89 1 Quote Link to comment Share on other sites More sharing options...
wraitii Posted November 15, 2020 Report Share Posted November 15, 2020 Rejoice everyone, for this is coming to svn (soon™) I've got a branch up and running on SM78 here: https://github.com/wraitii/0ad/tree/sm78 (with stops at SM60 and 68). Work is ongoing to upgrade svn to SM52. 1 4 Quote Link to comment Share on other sites More sharing options...
Bellaz89 Posted November 24, 2020 Author Report Share Posted November 24, 2020 Hi @wraitii Just a question: since in SM78 uneval() and .toSource() were removed, how did you get around that? did you modify the JS scripts or did you write a wrapper? Quote Link to comment Share on other sites More sharing options...
wraitii Posted November 24, 2020 Report Share Posted November 24, 2020 10 minutes ago, Bellaz89 said: Just a question: since in SM78 uneval() and .toSource() were removed, how did you get around that? did you modify the JS scripts or did you write a wrapper? They aren't actually removed yet You need to set the Realm creation option "SetToSourceEnabled" : https://github.com/wraitii/0ad/commit/08fe2e8e86a671228c3cffac6734e16b0b896087 I do think it'll probably be removed entirely in a future ESR, but in the interest of going fast I'll tackle that problem later. (BTW thanks for noticing the JS_PUBLIC_API thing of structure clones) 1 1 Quote Link to comment Share on other sites More sharing options...
Bellaz89 Posted November 24, 2020 Author Report Share Posted November 24, 2020 (edited) AH cool! I was not aware that it is possible to enable them! This simplifies the SM68 -> SM78 upgrade a lot . Edited November 24, 2020 by Bellaz89 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.