when unit levels up, he loses armor bonus from athens hero

[thankforpie]

despite being still in formation.

• clicking on formation button again solves this issue
• so on some units level up gives 1 armor. hero gives 3 armor.
• in my case it went from 6 armor to 4 armor on level up (6 - 3 from bonus = 3 + 1 armor from level up = 4)

[Guest]

Sounds like that renaming thing yet again.

[Stan`]

@(-_-) Do you have a link to a differential or a trac ticket ?

[Guest]

No.

But I do have a fix for something along the lines of what's reported. A regicide game would be lost if you promote your hero. D1694.

If I were to take a guess, I would be saying that whatever is handling that specific bonus is not listening to OnGlobalEntityRenamed and therefore considering the promoted unit dead. Dead units can't be in a formation and therefore it's doing the sensible thing of considering so.

Edit: Seems like Formations.js does not update auras when handling the message. Formations.js L926.

Edited January 2, 2019 by Guest

[Guest]

Something like the following may fix it.

  Reveal hidden contents

Index: Formation.js
===================================================================
--- Formation.js	(revision 21929)
+++ Formation.js	(working copy)
@@ -941,6 +941,12 @@
 		if (cmpNewUnitAI)
 			cmpNewUnitAI.SetFormationController(this.entity);
 
+		for (let ent of this.formationMembersWithAura)
+		{
+			let cmpAuras = Engine.QueryInterface(ent, IID_Auras);
+			cmpAuras.ApplyFormationBonus(msg.newentity);
+		}
+
 		// Because the renamed entity might have different characteristics,
 		// (e.g. packed vs. unpacked siege), we need to recompute motion parameters
 		this.ComputeMotionParameters();

 

 

[Stan`]

Thanks for looking into it. Can you submit a differential on Phabricator ? Thanks.

@elexis: Ping.

[Guest]

The issue would still probably persist in the case of the Aura Caster being renamed. Barring that, it’s mostly correct.

A diff’s a diff wherever it is posted,  feel free to commit the thing.

[Stan`]

  On 02/01/2019 at 1:00 PM, (-_-) said:

A diff’s a diff wherever it is posted,  feel free to commit the thing.

Expand  

Can't review code. Hence why I asked for it to be put on Phabricator  for other devs to review it.