Multiple unit UI not appearing

[Phalanx]

So, in the SVN version, the construction UI will not appear if multiple units are selected.

[jonbaer]

I think this is the error you will get ...

ERROR: JavaScript error: gui/session/selection_details.js line 416
ReferenceError: costIcon is not defined
  displayMultiple/numberOfUnits.tooltip<.details<@gui/session/selection_details.js:416:8
  displayMultiple@gui/session/selection_details.js:413:24
  updateSelectionDetails@gui/session/selection_details.js:466:3
  updateGUIObjects@gui/session/session.js:783:2
  onSimulationUpdate@gui/session/session.js:726:2
  __eventhandler65 (simulationupdate)@sn simulationupdate:0:1

[jonbaer]

Looks like according to https://github.com/0ad/0ad/commit/5c10d03826b535a5a26e1175f23e04e85beab3f2 this function was renamed to resourceIcon() + missed in few places (guess) ...

grep -R "costIcon" *
gui/session/selection_details.js:                    { "type": costIcon(res), "amount": totalCarrying[res] })).join("  "))
gui/session/selection_details.js:                    { "type": costIcon(res), "amount": totalLoot[res] })).join("  "))
gui/session/selection_panels.js:                "population": costIcon("population"),
gui/session/selection_panels.js:                costIcon(res) + data.carried[res]

resourceIcon.patch

Edited November 30, 2016 by jonbaer

[wowgetoffyourcellphone]

ERROR: JavaScript error: gui/session/selection_details.js line 425 ReferenceError: costIcon is not defined displayMultiple/numberOfUnits.tooltip<.details<@gui/session/selection_details.js:425:8 displayMultiple@gui/session/selection_details.js:422:24 updateSelectionDetails@gui/session/selection_details.js:466:3 updateGUIObjects@gui/session/session.js:764:2 onTick@gui/session/session.js:650:3 __eventhandler58 (tick)@sn tick:0:1

 

even after tooltip.js commit

[elexis]

Yes, it's my fault; fixed. Thanks for testing svn, the multiplayer svn games didn't start yet.