Submitting a patch, best practice?

[lucas92]

I've looked in the rendering code and I saw some possible optimizations. In the old code, at each frame the game had to calculate the patches to draw even if the frustum didn't change.

So I coded the changes and the game is slightly faster on my laptop when the screen is static. So, what are the best practices when submitting patches?

Thanks for responding.

Lucas Malo Bélanger

[niektb]

Any numbers to prove an improvement?

To answer your question: take a look at the wiki. Unfortunately it's down currently.

[lucas92]

Do you have a suggestion on how to measure this? I'm new to those built-in debug tools in 0.A.D.

[wraitii]

Hey lucas, usual procedure is opening a ticket on Trac, starting with [PATCH] since you'll post a patch too. It'll then be reviewed and if it's good we'll commit it.

However right now trac is down.

[lucas92]

Ok, with my tests, my code is faster about 15% on my laptop using this test procedure:

• Open Skirmish Alpine Valley (2)
• Calculate average time spent on sending patches.
• With old code, it takes about 66000 instructions to get to an average time of 0.003s. With the new code, it takes about 57000 instructions to get an average time of 0.003s.

I will open a ticket when the system will run again.

Lucas Malo Bélanger

[historic_bruno]

For patches related to optimization, I recommend looking at http://trac.wildfiregames.com/wiki/EngineProfiling and for all patches you'll want to look at http://trac.wildfiregames.com/wiki/SubmittingPatches (when the site is back up).

[lucas92]

Submitted my patch.

http://trac.wildfiregames.com/ticket/2431