[FIXED] Cppcheck: Mem leaks

[blublubb]

Hi guys,

have been playing 0 A.D. for a while now, and I like it pretty much!!!

As R13 is a bit delayed did check out sources yesterday have a look at the current state of development.

New features are amazing.

Then today had a look at sources with Cppcheck (http://cppcheck.sourceforge.net/) and it found some mem leaks.

[source\renderer\WaterManager.cpp:543]: (error) Memory leak: groundDirection

[source\renderer\WaterManager.cpp:543]: (error) Memory leak: waveForceHQ

Cannot say if they're valid because I really don't know your code structure at all, but we've found some nasty bugs while doing code for this:

http://www.benchmark...rum/content.php

So if nobody yet has done test run with Cppcheck, I highly recomend doing.

Cheers and keep on awsome work

Blulbubb

[quantumstate]

Thanks for running this. From an initial look this does look like a genuine leak, but I am not at my development PC so can't analyse it properly.

[fabio]

There is already a ticket for this: #1852.

[blublubb]

Hi guys,

There is already a ticket for this: #1852.

did a quick search in forum but not in track, soory then.

Cheers

Blublubb

[wraitii]

That's my code in the fancy water shader... Looking at it it appears like GroundDirection is obsolete code and should be removed alltogether. WaveforceHQ does appear to be incorrectly not deleted (probably should be done after its last use, or line 543 in WaterManager.cpp)

[historic_bruno]

Fixed.