Jump to content

phosit

WFG Programming Team
  • Posts

    84
  • Joined

  • Last visited

  • Days Won

    2

Posts posted by phosit

  1. 1 hour ago, hyperion said:
    1 hour ago, phosit said:

    @hyperion Does Fcollada also have an issue with newer lxbxml2 version?

    Looking at the linked ticket a future 2.12.3 should no longer have any issue, still technically it's a downstream bug, just that the fallout was unexpectedly large and the missing headers where injected back upstream. So I'd add the parser header regardless as this also allows the use of all 2.12.x releases.

    Right i used 2.12.1

    Can you upload a patch? (I'm shy of patching libraries)

    1 hour ago, vladislavbelov said:

    It seems a bit less readable to me and it'll be inconsistent anyway as we can't use such approach everywhere. But I don't mind in that particular case.

    To address the readability issue we could use a temporary/using.

    using MaybeConstXmlError = std::conditional_t<LIBXML_VERSION >= 21200, const xmlError, xmlError>;
    void errorHandler(void* UNUSED(userData), MaybeConstXmlError* error)
  2. Thank you for the work.

    I don't like preprocessor directives. We could go for:

    void errorHandler(void* UNUSED(userData), std::conditional_t<LIBXML_VERSION >= 21200, const xmlError, xmlError>* error)

    Also that wouldn't introduce duplication.

    @hyperion Does Fcollada also have an issue with newer lxbxml2 version? I get this errors:

    FCollada/FUtils/FUXmlDocument.cpp: In constructor ‘FUXmlDocument::FUXmlDocument(FUFileManager*, const fchar*, bool)’:
    FCollada/FUtils/FUXmlDocument.cpp:39:39: error: ‘xmlParseMemory’ was not declared in this scope
       39 |                         xmlDocument = xmlParseMemory((const char*) fileData, (int)fileLength);
          |                                       ^~~~~~~~~~~~~~
    FCollada/FUtils/FUXmlDocument.cpp: In constructor ‘FUXmlDocument::FUXmlDocument(const char*, size_t)’:
    FCollada/FUtils/FUXmlDocument.cpp:67:23: error: ‘xmlParseMemory’ was not declared in this scope
       67 |         xmlDocument = xmlParseMemory(data, (int)length);
          |                       ^~~~~~~~~~~~~~
    

     

  3. Spoiler

    Write a poem about how hard it is to get meat in the winter. And that one can use fields to get other forms of food.

    meta-llama:

    In days of old, when winter's chill did reign,
    Meat was a luxury, scarce and plain.
    The frozen fields lay barren, void of life,
    Leaving hunger pangs to plague our strife.

    But fear not, for in those frozen lands,
    There were still ways to feed our hands.
    We turned to fields of grain and green,
    Where other forms of sustenance were seen.

    The wheat and oats we harvested with care,
    Baked into bread, our bellies could bear.
    And from the gardens, vegetables galore,
    Stews and soups we made, and more.

    In winter's grip, we found a way,
    To survive each day, come what may.
    For though meat was a rarity,
    Our resourcefulness kept us in unity.

    So let us cherish these fields of gold,
    That give us life, both young and old.
    For in their bounty, we find a way,
    To thrive, even in winter's gray.

     

    • Haha 1
  4. Quote

    impossible to construct any 1st age buildings [...] at least houses were still allowed

    Why do you always write statements that contradict itself...

    Did you generate a  "Survival of the Fittest" before? Then it could be due to this bug.

    7 hours ago, Gurken Khan said:

    Maybe it was supposed to work like "Extinct Volcano" (I believe), where after some time indeed the whole map is flooded

    I'm working on such a diff :D (Not the whole map will be flooded)

×
×
  • Create New...