wraitii Posted July 9, 2012 Report Share Posted July 9, 2012 (edited) @zoot: I believe tickets are not used for "art" stuffs... I'll post in the forum, that'll be best.@myconid: that's probably the easiest... I just have to update your biwater with my patch. Edited July 9, 2012 by wraitii Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 Haven't been able to reproduce. Be more specific. Which map? GLSL or ARB?The screenshot above is from the 'Tropical Island' map with GLSL. The whole GLSL shadowmap implementation seems a bit shaky on my computer (the flickering etc.), but I do not experience this particular issue on 0ad/master. Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 @zoot: I believe tickets are not used for "art" stuffs... I'll post in the forum, that'll be best.For code, I do believe they prefer having a ticket to help everyone keep track of status, but we'll see. Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 The screenshot above is from the 'Tropical Island' map with GLSL. The whole GLSL shadowmap implementation seems a bit shaky on my computer (the flickering etc.), but I do not experience this particular issue on 0ad/master.The thing is, the minimap depends on the LOS code, not on the water shader. Make sure you're using the right shaders & you've recompiled. If that doesn't help, does this also occur in "merged"? Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 The thing is, the minimap depends on the LOS code, not on the water shader. Make sure you're using the right shaders & you've recompiled. If that doesn't help, does this also occur in "merged"?Yes, it does happen in merged. I'll try to see if it happens in smoothlos too. Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 On smoothlos, if I enable shadows, I get the flickering and the minimap turns completely black: Quote Link to comment Share on other sites More sharing options...
wraitii Posted July 9, 2012 Report Share Posted July 9, 2012 Okay, I got the AO and the self-light to work (along with the rest). AO looks so incredibly cool. Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 On smoothlos, if I enable shadows, I get the flickering and the minimap turns completely black:Ok, think I got it! Try either merged or smoothlos.Okay, I got the AO and the self-light to work (along with the rest). AO looks so incredibly cool.Awesome! Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 Ok, think I got it! Try either merged or smoothlos.Still getting the 'reveal minimap' issue on merged. Will try smoothlos now. Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 Still getting the 'reveal minimap' issue on merged. Will try smoothlos now.Does it still happen when smoothlos is disabled? Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 Does it still happen when smoothlos is disabled? Yes.But the black minimap issue seems to have been resolved on the smoothlos branch. Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 I get the 'reveal minimap' issue on both merged and smoothlos now, though. Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 Ok, let's stick to the smoothlos branch for now because this is definitely a LOS-related bug. So far your findings tell us that this happens when preferglsl is true and happens regardless of whether smoothlos is enabled in the config or not. Is this correct? Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 So far your findings tell us that this happens when preferglsl is true and happens regardless of whether smoothlos is enabled in the config or not. Is this correct?It happens when preferglsl is true and smoothlos is true or false and shadows are enabled, yes. Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 (edited) Hmm. It also happens on this commit:commit 9ef088e531f4f16ce7df773c4336c60bd272bb41Author: myconid <christofi.cos@gmail.com>Date: Thu Jun 21 14:30:34 2012 +0300 Windy trees; Basic Time Manager; RenderQueriesWhich would suggest that it goes way back and is unrelated to smooth LOS. Edited July 9, 2012 by zoot Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 (edited) Okay, keep going.Let's switch to the modelmapping branch. Check if this also occurs there. Edited July 9, 2012 by myconid Quote Link to comment Share on other sites More sharing options...
wraitii Posted July 9, 2012 Report Share Posted July 9, 2012 I've finished porting the modelCommon shader. I'm moving on to the terrainCommon, but I can already tell the triplanar stuff is going to be a huge pain. Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 I've finished porting the modelCommon shader. I'm moving on to the terrainCommon, but I can already tell the triplanar stuff is going to be a huge pain.NB: terrainCommon isn't cleaned up and may still change. Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 Okay, keep going.Let's switch to the modelmapping branch. Check if this also occurs there.Currently trying a commit on 0ad/master to see if it is even something in your repo. Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 Ahem, it does happen on the latest commit on 0ad/master also. I must have botched my first test and forgot to set glsl to true or not moved the camera enough for the bug to show.Anyway, it is a bug in the engine, not in your changes. Quote Link to comment Share on other sites More sharing options...
myconid Posted July 9, 2012 Author Report Share Posted July 9, 2012 I'm relieved, as I had no clue what in my changes could be causing this, other than the LOS changes that we ruled out.Still, we should get this fixed! I'll look at the minimap code tonight (it seems like it's using old-style OpenGL calls to do the drawing).Anyway, enough multi-multi-multi-tasking, back to multi-multi-tasking so I can get some work done. Quote Link to comment Share on other sites More sharing options...
wraitii Posted July 9, 2012 Report Share Posted July 9, 2012 Ported the grass shader, and ensured the rest was working. I won't modify terrainCommon any more, since everything else is both complicated and an WIP. Quote Link to comment Share on other sites More sharing options...
wraitii Posted July 9, 2012 Report Share Posted July 9, 2012 (edited) Allright, I've ported the water shader (slightly modified), experimental grass, moving trees and modelMapping as a whole. Download here.Edit: should check, but the ARB shader might have grass' alpha decreasing with each layer. T'was a test. Edited July 9, 2012 by wraitii Quote Link to comment Share on other sites More sharing options...
zoot Posted July 9, 2012 Report Share Posted July 9, 2012 (edited) Allright, I've ported the water shader (slightly modified), experimental grass, moving trees and modelMapping as a whole. Download here.Edit: should check, but the ARB shader might have grass' alpha decreasing with each layer. T'was a test.I'm getting this when doing update-workspaces.sh:make[1]: Premake4.make: No such file or directory Edited July 9, 2012 by zoot Quote Link to comment Share on other sites More sharing options...
wraitii Posted July 9, 2012 Report Share Posted July 9, 2012 Ah, it's possible I have inadvertantly deleted som files when trying to use gitignore. You can use SVN premake meanwhile. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.