Mythos_Ruler Posted May 1, 2014 Report Share Posted May 1, 2014 Attached files: commands.txt, interestinglog.html, system_info, and main log.erros.zip Quote Link to comment Share on other sites More sharing options...
sanderd17 Posted May 2, 2014 Report Share Posted May 2, 2014 Doesn't look like an issue with Petra. But something more related to the i18n code (sprintf giving the first errors). I'll research it (thanks for the commands.txt, as apparently, it's not that easy to reproduce. Quote Link to comment Share on other sites More sharing options...
mimo Posted May 2, 2014 Report Share Posted May 2, 2014 The first two errorsERROR: JavaScript error: uncaught exception: [sprintf] property "name" does not existandWARNING: JavaScript warning: gui/common/timer.js line 64 have appeared when the I18n code was commited. And for me, I appears only when changing perspective and taking the AI player (both aegis and petra). I've made a ticket for the first one http://trac.wildfiregames.com/ticket/2485 The last error ERROR: JavaScript error: simulation/ai/common-api/utils.js line 23 is certainly a petra error. I will have a look at it. Quote Link to comment Share on other sites More sharing options...
sanderd17 Posted May 2, 2014 Report Share Posted May 2, 2014 I thought the first ones were causing further issues (which would be a bug on its own, as the translation should never change the simulation). I have improved the sprintf error reports, so now it should be easier to find the cause. Quote Link to comment Share on other sites More sharing options...
sanderd17 Posted May 2, 2014 Report Share Posted May 2, 2014 Ok, fixed that sprintf problem (and harmonized the code around it a bit). The fix is attached here, as Trac is down now (so if I'm not available, anyone can commit it). EDIT: found Philip, Trac works, uploaded patch.messages_fix.diff Quote Link to comment Share on other sites More sharing options...
mimo Posted May 2, 2014 Report Share Posted May 2, 2014 Mythos_Ruler, thanks for the report. The petra error is fixed in svn r15092sanderd17, thanks for the fix on sprintf ! Were you also able to reproduce the one on timer.js ? It also appeared for me when the I18n code was introduced, but may-be due to some "Change perspective" feature ? Quote Link to comment Share on other sites More sharing options...
sanderd17 Posted May 2, 2014 Report Share Posted May 2, 2014 The timer problem was because sprintf threw a string instead of an Error object. Thus that string didn't have a stacktrace, and that's the error you saw in timer.jsI think it's good coding practice if we expect that anything that's thrown also had a trace, so i fixed sprintf rather than the timer. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.