new AI bug: Incorrect unitAI state behavior on fishing boats

[rjs23]

There is a strange behavior how fishing boats behave after the fish resource is used up. I have my AI to reassign the fishing boat when it becomes IDLE but some fishing boat never seem to enter INDIVIDUAL.GATHER.IDLE at all. Instead it does the never-ending loop of INDIVIDUAL.GATHER.APPROACHING and INDIVIDUAL.GATHER.GATHERING (gathering what? there is no fish resource there anymore). Some won't enter IDLE status when fishing boat is sitting doing nothing. I have to assign it manually to reset the never-ending loop status bug.

I've attached the saved file (it has my AI bot, but I think this behavior still occur without my bot). Remove .txt extension (board won't let me its orginal format otherwise.

http://img1.uploadsc...050818-orig.jpg

There used to be more but I had to manually assigned all but one (that in screenshot).

This behavior could cause unexpected bug in AI with water units

quicksave-0005.0adsave.txt

Edited August 21, 2012 by rjs23

[historic_bruno]

You're correct, this is reproducible on a test map without AIs. I'm not sure it's fishing boat specific though. The problem seems to be when a unit is gathering from a resource supply such that the gatherer reaches max capacity at the same time the resource supply becomes exhausted - which is quite likely if there's a single gatherer and the supply is an integer multiple of that gatherer's capacity (multiplied by the gather rate?). The gatherer never becomes aware that the supply was exhausted (which would cause it to give up on the current target) so it enters the infinite loop of gathering "near" the last target, which of course no longer exists.

[Deiz]

I was nervous for a moment (thinking my recent changes broke something) but this is also present in alpha 10.

There must be some special case that's being hit here, because land gatherers can switch from one resource to another without issue.