Jump to content

Some animations are broken (gathering and other)


Mr.lie
 Share

Recommended Posts

55 minutes ago, Nescio said:

You could try:


git restore simulation/templates/*

Though I suspect that has no effect in this case, since you already committed your changes.

Which means you'll have to open the affected files, manually revert the changes you made, and save the files.

Once you've done them all, commit them again:


git add *
git commit -m "address requested changes"
git push https://github.com/mrlie58/millenniumad

 

DONE - sorry for the trouble i've made :(

Link to comment
Share on other sites

27 minutes ago, Mr.lie said:

DONE - sorry for the trouble i've made :(

No need to apologize, we're fully aware you're new to this, still learning, and have the best of intentions.

Unfortunately, you're not done yet:

twomore.thumb.png.84dc051848098cfd4b2949ee6013be4a.png

Please restore the indentation in those two templates ( https://github.com/0ADMods/millenniumad/pull/55/files#diff-62763f015915eda05180f3deb3b47f3f ).

Link to comment
Share on other sites

7 minutes ago, Nescio said:

No need to apologize, we're fully aware you're new to this, still learning, and have the best of intentions.

Unfortunately, you're not done yet:

twomore.thumb.png.84dc051848098cfd4b2949ee6013be4a.png

Please restore the indentation in those two templates ( https://github.com/0ADMods/millenniumad/pull/55/files#diff-62763f015915eda05180f3deb3b47f3f ).

Done, i'll hope this time correct :unsure:

  • Like 2
Link to comment
Share on other sites

I guess fixing the pickaxes migth have been easier :D

But yeah it will need some thinking. Also I notice you are using A23B horses, which are different from A24 horses, and that might play against you : S  Another solution would be to reverse the horses :)

 

Link to comment
Share on other sites

4 hours ago, asterix said:

@Mr.lie there are some new comments https://github.com/0ADMods/millenniumad/pull/55  by  @Stan`

Sorry, i saw the comments from @Stan` but thought it was just an information that he has this done. So, i've just correct the two files online, as nescio said. I'll hope this time it's correct.

Edited by Mr.lie
  • Like 1
Link to comment
Share on other sites

On 7/8/2020 at 12:31 AM, Mr.lie said:

Hello guys,

i've noticed that some variants are broken:

    <prop actor="props/units/tools/pick.xml" attachpoint="weapon_R"/> seems to be ok,

    <prop actor="props/units/tools/pick.xml" attachpoint="weapon_L"/> seems to be not ok

by the girls all three variants are wrong, by the guys only "gather_ruins"

 

gather_rock.thumb.png.2673cae2e124afda8f5ba8f6ea81ceb1.png

 

 

gather_ruins.thumb.png.e9a0912c1a94f72a0ac224655ff6d9c2.png

gather_ore.thumb.png.f3b4271edd9c5de50cb4b736c1190977.png

female_gather_ruins.thumb.png.3a7ef5608af6779390c79216146b466f.png

female_gather_ore.thumb.png.11ef000ded9efffff900aeaec2462be6.png

female_gather_rock.thumb.png.a1b46764d6bf03b9e5455730ecf2ff3b.png

@Stan` fix in https://github.com/0ad/0ad/pull/32/commits/f0902554667d13fdc196380c067086ce1e5a1b9a

Link to comment
Share on other sites

Auf der o.g. Seite habe ich gelesen:

Quote

Ideally, those changes are already described in one of our Trac tickets, so you know it is wanted. It would be a shame if you put some effort in a code that we actually don't want. If your change is a feature, it needs to have a ticket associated so we can discuss whether the feature is wanted and how. If it is a bugfix or a tiny change in the code, it's not mandatory to create a new ticket.

Ich habe die issues zwar gepostet, aber es gibt ja keine Tickets darüber. Vielleicht wünscht Ihr dies ja garnicht :unsure:

Link to comment
Share on other sites

8 minutes ago, Stan` said:

Well if it fixes an art but I'll have them. I'd like to understand why we need relax back instead of ready though

There are 4 variants for rider-cavalry-archer:

  • base_archer_fast_back.xml
  • base_archer_fast_hip.xml
  • base_archer_relax_back.xml
  • base_archer_relax_hip.xml

The Persian champion_cavalry_archer is the only one with the quiver on his back, all the other (there are only 2 other in the main-game) have their quiver on the left side. As there are two different variants they need to be named different.

Another question: with "art" you mean "artist"?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...