Jump to content

SVN21848 ERROR!


gameboy
 Share

Recommended Posts

@elexis Today, I tested the latest SVN21847. When I opened the multiplayer lobby, the error message appeared: 

ERROR: RelaxNGValidator: Validation error: gui/prelobby/common/credentials/credentials.xml:2: Did not expect text in element object content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: CXeromyces: failed to validate XML file gui/prelobby/common/credentials/credentials.xml

  • Thanks 1
Link to comment
Share on other sites

Thanks gameboy!

I did not notice the bug because there is a logic problem in the XML library that is hiding this bug. :angel_not:

The library saves syntactically correct cached versions of syntactically incorrect XML files, so we see the error the first time, but then never again.

So if a dev has some errorspam and only read the first error, he may never have a chance to read this error and is mislead to believe that the XML files are syntactically and semantically correct and commit them.

Hence I propose to only save the syntactically correct cached files if the XML files were syntactically correct as well in D1574.

  • Thanks 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...