Jump to content

lobby WARNING!!!


gameboy
 Share

Recommended Posts

When selecting the "Set message of the day and send to online users" as a lobby moderator in option in pidgin, the following JS error occurs with alpha 22:

WARNING: JavaScript warning: gui/lobby/lobby.js line 232
reference to undefined property msg.from
WARNING: JavaScript warning: gui/lobby/lobby.js line 232
Script value conversion check failed: v.isString() || v.isNumber() (got type undefined)
  • Like 1
Link to comment
Share on other sites

That what fatherbushido said. In addition it seems that other messages can trigger it too, because I didn't send such a message today (nor some time ago when this was reported in irc). I had that error few days ago but not today, so can't find out which comment we should add to the easy fix.

  • Like 1
Link to comment
Share on other sites

He has mentioned that it is an intermittent bug (he can not reproduce it ) and they are the hardest bugs to fix as they seem random the only solution is time so back off and give him that time bugs can not be fixed as soon as they show up they need analysis not demands.

Enjoy the Choice :) 

  • Like 2
  • Haha 1
Link to comment
Share on other sites

16 minutes ago, gameboy said:

@elexisyes, i get it on every login.

Ok, that's good so far!

@gameboy can you test this patch and give the output?

Quote

Index: binaries/data/mods/public/gui/lobby/lobby.js
===================================================================
--- binaries/data/mods/public/gui/lobby/lobby.js    (revision 19985)
+++ binaries/data/mods/public/gui/lobby/lobby.js    (working copy)
@@ -227,10 +227,11 @@ var g_NetMessageTypes = {
                 "text": escapeText(msg.text),
                 "time": msg.time
             });
         },
         "private-message": msg => {
+            warn(uneval(msg));
             if (Engine.LobbyGetPlayerRole(msg.from) == "moderator")
                 // some XMPP clients send trailing whitespace
                 addChatMessage({
                     "from": escapeText(msg.from),
                     "text": escapeText(msg.text.trim()),

 

  • Like 1
Link to comment
Share on other sites

@elexisOK,  I used the patch you provided, and I got the warning message. I sent the message to the online user via pidgin.

WARNING: ({type:"chat", text:"hello", level:"private-message", time:1503030232})

WARNING: JavaScript warning: gui/lobby/lobby.js line 233 reference to undefined property msg.from

WARNING: JavaScript warning: gui/lobby/lobby.js line 233 Script value conversion check failed: v.isString() || v.isNumber() (got type undefined)

Engine exited successfully on 2017-08-18 at 12:24:16 with 620 message(s), 0 error(s) and 3 warning(s).

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...