Jump to content

===[TASK]=== Hippo


Micket
 Share

Recommended Posts

I would

16 hours ago, Nescio said:

However, I do like consistency, and e.g.


<food>200</food>
<wood>50.0</wood>

is ugly.

I like consistency too, I guess that's why I discuss about that with you.

I would recommend

<food>200.0</food>
<wood>50.0</wood>

and even (if needed)

<food>200.0</food>
<wood>0.0</wood>

About rP22408 that should have been discussed as in recomanding exactly the converse of removing trailing zeros for modifications.

As I said above the argument is different for templates and modifications but it's about the same kind of issues.

Link to comment
Share on other sites

1 hour ago, fatherbushido said:

I would

I like consistency too, I guess that's why I discuss about that with you.

I would recommend


<food>200.0</food>
<wood>50.0</wood>

and even (if needed)


<food>200.0</food>
<wood>0.0</wood>

About rP22408 that should have been discussed as in recomanding exactly the converse of removing trailing zeros for modifications.

As I said above the argument is different for templates and modifications but it's about the same kind of issues.

Could you explain why?

As for rP22408, I don't remember the details (@bb_?), but I guess changing e.g. armor_hero_01.json from

"cost": {"food": 0, "wood": 0, "stone": 0, "metal": 600},
"modifications": [
	{"value": "Armour/Hack", "add": 2.0},
	{"value": "Armour/Pierce", "add": 2.0},
	{"value": "Cost/Resources/metal", "add": 50}],

to

"cost": { "food": 0, "wood": 0, "stone": 0, "metal": 600 },
"modifications": [
	{ "value": "Armour/Hack", "add": 2 },
	{ "value": "Armour/Pierce", "add": 2 },
	{ "value": "Cost/Resources/metal", "add": 50 }
],

was a lesser change compared to changing it into

"cost": { "food": 0.0, "wood": 0.0, "stone": 0.0, "metal": 600.0 },
"modifications": [
	{ "value": "Armour/Hack", "add": 2.0 },
	{ "value": "Armour/Pierce", "add": 2.0 },
	{ "value": "Cost/Resources/metal", "add": 50.0 }
],

Also, there were things such as

"add": 0.10

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...